Skip to content

Migrate commons-lang2 to lang3 - #781

Merged
michael-doubez merged 2 commits into
jenkinsci:masterfrom
gbhat618:migrate-lang2-to-lang3
Jul 30, 2026
Merged

Migrate commons-lang2 to lang3#781
michael-doubez merged 2 commits into
jenkinsci:masterfrom
gbhat618:migrate-lang2-to-lang3

Conversation

@gbhat618

Copy link
Copy Markdown
Contributor

Prepare for jenkinsci/jenkins#26105 by removing lang2 usages.
lang3-api is already a dependency here, so just migrate the import to there

oic-auth-plugin/pom.xml

Lines 97 to 100 in f202e42

<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>commons-lang3-api</artifactId>
</dependency>

Testing done

  • compilation successful with a local jenkins without having lang2 in it - mvn clean compile -Djenkins.version=2.574-SNAPSHOT

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@gbhat618
gbhat618 requested a review from a team as a code owner July 22, 2026 11:14
@gbhat618

Copy link
Copy Markdown
Contributor Author

Need a release for it to test in jenkinsci/bom#6234, a label developer would work (label choose discussion jenkinsci/dockerhub-notification-plugin#94 (comment))

@gbhat618

Copy link
Copy Markdown
Contributor Author

Hi @michael-doubez,
Requesting your help move this PR, we will need to add developer label to get release as well.
Please help. ty.

@michael-doubez michael-doubez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-doubez
michael-doubez merged commit e731df6 into jenkinsci:master Jul 30, 2026
18 checks passed
@gbhat618
gbhat618 deleted the migrate-lang2-to-lang3 branch August 3, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants