Remove usages of Commons Lang 2 - #2
Open
timja wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No need to depend on a third-party library here when the Java Platform provides this
functionality natively.
Part of the effort to remove Commons Lang 2 from Jenkins core — jenkinsci/jenkins#16404,
jenkinsci/jenkins#26105. Commons Lang 2 is EOL and carries an unfixed advisory
(GHSA-j288-q9x7-2f5v).
What's changed
Rewritten in plain Java — this plugin has no BOM and an
org.jvnet.hudson.plugins:plugin:1.395parent, so neither
commons-lang3-apinor a directcommons-lang3dependency is usable.MutableInt(a mutable counter in maps) becomesjava.util.concurrent.atomic.AtomicInteger.ToStringBuilder.reflectionToString(this, DEFAULT_STYLE)becomes explicittoString()implementations listing the same fields. The output format changes slightly (it is only used for
logging), but no longer depends on reflection.
StringUtils.isEmpty/isNotEmptybecome plain null pluslength()checks.Testing done
mvn -B -ntp clean verifyfails locally inmaven-hpi-plugin:1.57:apt-compile, which cannot runon a modern JDK — reproducible on an unmodified checkout.
The
ban-commons-lang-2enforcer rule was left disabled: the parent POM predates the rule entirely.Submitter checklist
🤖 This pull request was generated with AI assistance (Claude Code) as part of a bulk migration
across Jenkins plugins. If anything here looks wrong, please comment on this PR or contact @timja.