Skip to content

[FIX JENKINS-33698] NodeJS plugin npm install without root permissions - #13

Closed
nfalco79 wants to merge 2 commits into
jenkinsci:masterfrom
nfalco79:feature/JENKINS-33698
Closed

[FIX JENKINS-33698] NodeJS plugin npm install without root permissions#13
nfalco79 wants to merge 2 commits into
jenkinsci:masterfrom
nfalco79:feature/JENKINS-33698

Conversation

@nfalco79

Copy link
Copy Markdown
Member

For NodeJS >= 6.x version the "prefix" variable is relocated to local
installation tools folder as previous version. This settings could be
override using the npmrc file hierarchy. If a prefix variable is already
present in the default settings of local installation is kept.

For NodeJS >= 6.x version the "prefix" variable is relocated to local
installation tools folder as previous version. This settings could be
override using the npmrc file hierarchy. If a prefix variable is already
present in the default settings of local installation is kept.
@mplsbk

mplsbk commented Oct 17, 2016

Copy link
Copy Markdown

When is this going to be merged and published? this is currently a blocker on my project.

@nfalco79

Copy link
Copy Markdown
Member Author

I've not proceed to merge this fix and the reason is that the master branch code has update the way to contribuite environment variables. That is cool but if a new release will be released the plugin will not work if the EnvInject plugin was installed.

But you have reason. I could ask to merge this fix in master but no release new one untill EnvInject will resolve this PR

@tfennelly

Copy link
Copy Markdown
Member

Maybe you are already aware of this, but the plugin parent pom already contains maven profiles for the frontend-maven-plugin, which will add npm and node locally to your build. The older versions of the profiles assumed your build was using gulp, but 2.17 and after (if there's been one since) just run npm scripts ("mvnbuild" and mvntest).

Just Fyi ... maybe it does not help you !!

@nfalco79

Copy link
Copy Markdown
Member Author

I use frontend-maven-plugin to build npm project as part of war project or to trasform web project into web bundle deployable in Java EE/OSGi container.
But this fix is needed to build all our pure npm (no gulp) project library and release it on our internal npm repo.
Our frontend programmers do not like embed their project into maven container.

tfennelly, thank for the tips

@nfalco79

Copy link
Copy Markdown
Member Author

This PR is not needed.
Commit f38e0a5 already close this issue. I will release a 0.2.2 with just that fix when they give me permission to deploy new release.

@nfalco79 nfalco79 closed this Dec 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants