Skip to content

Remove deprecated extended-choice-parameter plugin integration #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olamy merged 1 commit into from
Aug 12, 2026
+0 −84
Merged

Remove deprecated extended-choice-parameter plugin integration #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,6 @@
<version>4.3.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>extended-choice-parameter</artifactId>
<version>388.ve7b_d0b_920e10</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>git</artifactId>
Expand Down
15 changes: 0 additions & 15 deletions src/main/java/io/jenkins/plugins/mcp/server/extensions/util/ParameterValueFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
import hudson.model.StringParameterDefinition;
import hudson.model.TextParameterDefinition;
import java.util.List;
import java.util.stream.Collectors;
import lombok.extern.slf4j.Slf4j;

/**
Expand All @@ -50,8 +49,6 @@ public final class ParameterValueFactory {
"net.uaznia.lukanus.hudson.plugins.gitparameter.GitParameterDefinition";
public static final String LIST_GIT_BRANCHES_PARAMETER_DEFINITION =
"com.syhuang.hudson.plugins.listgitbranchesparameter.ListGitBranchesParameterDefinition";
public static final String EXTENDED_CHOICE_PARAMETER_DEFINITION =
"com.cwctravel.hudson.plugins.extended_choice_parameter.ExtendedChoiceParameterDefinition";
public static final String VALIDATING_STRING_PARAMETER_DEFINITION =
"hudson.plugins.validating_string_parameter.ValidatingStringParameterDefinition";

Expand All @@ -69,8 +66,6 @@ public static ParameterValue createParameterValue(ParameterDefinition param, Obj
return createGitParameterValue(param, inputValue);
} else if (isParameterDefinitionOf(param, LIST_GIT_BRANCHES_PARAMETER_DEFINITION)) {
return createListGitBranchesParameterValue(param, inputValue);
} else if (isParameterDefinitionOf(param, EXTENDED_CHOICE_PARAMETER_DEFINITION)) {
return createExtendedChoiceParameterValue(param, inputValue);
} else if (isParameterDefinitionOf(param, VALIDATING_STRING_PARAMETER_DEFINITION)) {
return createParameterValueViaCli(param, String.valueOf(inputValue));
} else if (param instanceof StringParameterDefinition) {
Expand Down Expand Up @@ -190,16 +185,6 @@ private static ParameterValue createListGitBranchesParameterValue(ParameterDefin
return createParameterValueViaCli(param, String.valueOf(inputValue));
}

private static ParameterValue createExtendedChoiceParameterValue(ParameterDefinition param, Object inputValue) {
String valuesAsString;
if (inputValue instanceof List<?> l) {
valuesAsString = l.stream().map(Object::toString).collect(Collectors.joining(","));
} else {
valuesAsString = String.valueOf(inputValue);
}
return createParameterValueViaCli(param, valuesAsString);
}

private static ParameterValue createParameterValueViaCli(ParameterDefinition param, String inputValue) {
String paramTypeName = param.getClass().getSimpleName();
try {
Expand Down
63 changes: 0 additions & 63 deletions .../plugins/mcp/server/extensions/util/ParameterValueFactoryExtendedChoiceParameterTest.java
View file
Open in desktop

This file was deleted.