[WIP] Test several pull requests - #27190
Closed
MarkEWaite wants to merge 259 commits into
Closed
Conversation
…on slow file systems.
move the controls to launch or mark offline to the main app-bar so it is available on each subpage
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…/major-stapler.version
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
From Jenkins pom release: * https://github.com/jenkinsci/pom/releases/tag/2.1389.veca_379b_b_e95c
From Jenkins pom release: * https://github.com/jenkinsci/pom/releases/tag/2.1389.veca_379b_b_e95c
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…'enable-annotation-processor-path', 'enable-top-button-for-heterolist', 'fix-26919-touch-doubletap', 'fix-26920-combobox-flash', 'fix-context-menu-post-notification', 'fix-global-search-job-name-display-name', 'fix/14784-limit-rss-changelog', 'fix/console-model-link-hover', 'fix/jenkins-75310-log-recorder-level', 'fix/quotedstringtokenizer-quote-javadoc-contract', 'fix/sortable-date-12am-midnight', 'individual-scrollers', 'issue/21047', 'jnowjack-abort-instead-of-fail' and 'login-page-password-ux' into Aardvark-Octopus
…ove-view-read', 'renovate/com.github.eirslett-frontend-maven-plugin-2.x', 'renovate/com.puppycrawl.tools-checkstyle-13.x', 'renovate/globals-17.x', 'renovate/lock-file-maintenance' and 'renovate/major-stapler.version' into Aardvark-Octopus
…24.x', 'renovate/org.jenkins-ci-jenkins-2.x', 'renovate/org.jenkins-ci.plugins-matrix-project-905.x' and 'renovate/org.xmlunit-xmlunit-bom-2.x' into Aardvark-Octopus
…novate/webpack-5.x' into Aardvark-Octopus
Includes pull requests: * jenkinsci#27183 * jenkinsci#27182 * jenkinsci#27181 * jenkinsci#27180 * jenkinsci#27179 * jenkinsci#27178 * jenkinsci#27176 * jenkinsci#27175 * jenkinsci#27174 * jenkinsci#27173 * jenkinsci#27173 * jenkinsci#27172 * jenkinsci#27171 * jenkinsci#27170 * jenkinsci#27169 * jenkinsci#27165 * jenkinsci#27162 * jenkinsci#27161 * jenkinsci#27153 * jenkinsci#27152 * jenkinsci#27129 * jenkinsci#27088 * jenkinsci#27083 * jenkinsci#27067 * jenkinsci#27065 * jenkinsci#27063 * jenkinsci#27032 * jenkinsci#27029 * jenkinsci#26923 * jenkinsci#26922 * jenkinsci#26913 * jenkinsci#26880 * jenkinsci#26863 * jenkinsci#26690 * jenkinsci#26668 * jenkinsci#26600 * jenkinsci#26587 * jenkinsci#25920 * jenkinsci#11216 * jenkinsci#10432
Contributor
There was a problem hiding this comment.
Pull request overview
This WIP PR is a “test merge” of many separate changes across Jenkins core, spanning UI/UX updates (login/register, side panels, experimental agent pages), security/permissions adjustments around views, backend/runtime fixes, new “core-libs” packaging plumbing, and assorted dependency/tooling updates.
Changes:
- Add/adjust multiple UI features and layout behaviors (password visibility + Caps Lock indicator, agent page revamp behind a flag, side panel/layout/sticky styling updates, dropdown UX tweaks).
- Update view permission behavior (deprecate
View.READusage in tests/CLI paths, useView.EXTENDED_READwhere configuration/XML access is intended). - Introduce core-libs packaging helpers and sanitize update-site plugin excerpts, plus misc reliability/perf fixes (e.g., retry rename), and dependency/tooling bumps.
Reviewed changes
Copilot reviewed 228 out of 239 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| websocket/spi/pom.xml | Disable annotation processing for websocket SPI module. |
| websocket/jetty12-ee9/pom.xml | Configure compiler annotationProcessorPaths for websocket Jetty 12 module. |
| webpack.config.js | Add webpack entry for sign-in page bundle. |
| war/src/main/webapp/scripts/sortable.js | Fix 12 AM parsing so midnight sorts correctly. |
| war/src/main/webapp/scripts/hudson-behavior.js | Improve AutoScroller viewport vs element scroll handling. |
| war/src/main/resources/images/symbols/eye-outline.svg | Add eye icon for password visibility toggle. |
| war/src/main/resources/images/symbols/caps-lock.svg | Add caps lock icon for indicator. |
| war/extract-core-lib-artifact-ids.groovy | Extract core-libs artifact IDs for packaging/excludes. |
| test/src/test/resources/jenkins/install/LoadDetachedPluginsTest/upgradeFromJenkins2/jenkins.install.InstallUtil.lastExecVersion | Remove lastExecVersion test fixture file. |
| test/src/test/resources/hudson/classicpluginstrategydisableddep/test-resource | Add shared test resource fixture marker. |
| test/src/test/java/lib/form/PasswordTest.java | Update view permission in test to use View.EXTENDED_READ. |
| test/src/test/java/jenkins/security/Security1809Test.java | Adjust authorization expectations with deprecated View.READ. |
| test/src/test/java/jenkins/plugins/detachedtest/Marker.java | Add marker class used for synthetic plugin tests. |
| test/src/test/java/jenkins/core/PluginExcerptSanitizerTest.java | Add test coverage for core-lib excerpt sanitizer retrieval/behavior. |
| test/src/test/java/jenkins/core/corelib_test_plugin/ClassLoaderProbe.java | Add classloader probe helper for core-libs isolation tests. |
| test/src/test/java/hudson/security/HudsonPrivateSecurityRealmTest.java | Add tests for login/signup password toggle + Caps Lock indicator. |
| test/src/test/java/hudson/search/SearchTest.java | Extend search completion test to include display-name matching and adjust view visibility expectations. |
| test/src/test/java/hudson/PluginManagerTest.java | Add test ensuring /pluginManager/api/json exports plugin details at default depth. |
| test/src/test/java/hudson/model/ViewTest.java | Update permissions in view-related test setup. |
| test/src/test/java/hudson/model/Security3349Test.java | Update permissions in agent view access test. |
| test/src/test/java/hudson/diagnosis/TooManyJobsButNoViewTest.java | Remove View.READ requirement from test setup. |
| test/src/test/java/hudson/cli/RemoveJobFromViewCommandTest.java | Update CLI view tests to remove deprecated View.READ grants. |
| test/src/test/java/hudson/cli/GetViewCommandTest.java | Update get-view CLI tests for View.EXTENDED_READ requirements and messaging. |
| test/src/test/java/hudson/cli/CLIActionTest.java | Update expected exit code semantics when view read permission no longer applies. |
| src/main/scss/pages/_plugin-manager.scss | Remove sticky sidebar styling for plugin manager. |
| src/main/scss/pages/_job.scss | Remove side-panel-specific build history margin override. |
| src/main/scss/pages/_index.scss | Include new agent page SCSS. |
| src/main/scss/form/_reorderable-list.scss | Add top-button margin styling for hetero lists. |
| src/main/scss/components/_side-panel-widgets.scss | Remove pane-frame left margin tweak. |
| src/main/scss/components/_side-panel-tasks.scss | Adjust side-panel task padding/margins and introduce inset variable. |
| src/main/scss/components/_page-footer.scss | Hide page footer by default. |
| src/main/scss/components/_breadcrumbs.scss | Fix breadcrumb list margin and hover/open sizing/chevron behavior. |
| src/main/scss/components/_app-bar.scss | Adjust app bar sizing and sticky behavior/appearance. |
| src/main/scss/base/_sticky.scss | Update sticky-disable behavior for new layout elements and build bar. |
| src/main/scss/base/_core.scss | Change global overscroll/background behavior. |
| src/main/scss/abstracts/_theme.scss | Adjust theme variables (header background/height, section padding, border radius). |
| src/main/js/util/password-field.js | Add shared password field toggle + Caps Lock indicator logic. |
| src/main/js/pages/sign-in/index.js | Initialize password field enhancements on sign-in page. |
| src/main/js/pages/register/index.js | Replace old “Show” checkbox logic with shared password field enhancements. |
| src/main/js/components/notifications/index.js | Show queued dropdown notification after navigation via sessionStorage. |
| src/main/js/components/header/index.js | Remove scroll-driven header fade behavior and some sticky detection logic. |
| src/main/js/components/dropdowns/templates.js | Queue POST action success/failure notification before redirect. |
| src/main/js/components/dropdowns/autocomplete.js | Prevent focusout from closing dropdown when focus moves into the popper. |
| package.json | Bump frontend tool versions (globals, postcss, webpack, yarn). |
| core/src/spotbugs/excludesFilter.xml | Add excludes for new SpotBugs patterns in specific lambdas. |
| core/src/main/resources/lib/layout/side-panel.jelly | Remove sticky side-panel attribute and sticky class emission. |
| core/src/main/resources/lib/layout/layout.jelly | Adjust page-body structure and main-panel container usage. |
| core/src/main/resources/lib/hudson/project/config-publishers2.jelly | Enable hetero-list top add button for post-build actions. |
| core/src/main/resources/lib/hudson/project/config-builders.jelly | Enable hetero-list top add button for build steps. |
| core/src/main/resources/lib/hudson/progressive-text.js | Broaden scroll container selection for progressive text output. |
| core/src/main/resources/lib/hudson/actions.jelly | Render ConfirmationEvent actions as POST tasks with confirmation. |
| core/src/main/resources/lib/form/repeatableHeteroProperty.jelly | Plumb new enableTopButton attribute through repeatable hetero property. |
| core/src/main/resources/jenkins/views/JenkinsHeader/logo.jelly | Add tooltip with Jenkins version on logo. |
| core/src/main/resources/jenkins/model/Jenkins/login.jelly | Add sign-in JS bundle and new password toggle + Caps Lock indicator markup. |
| core/src/main/resources/jenkins/model/details/MonitoringDetails/detail.jelly | Add dialog-based rendering for monitoring details. |
| core/src/main/resources/jenkins/model/agent/Messages.properties | Add titles for agent page actions. |
| core/src/main/resources/jenkins/agent/OverviewTab/index.properties | Add new agent overview localization keys. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_zh_TW.properties | Add/update Traditional Chinese localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_uk.properties | Add Ukrainian localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_tr.properties | Add Turkish localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_sv_SE.properties | Add Swedish localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_sr.properties | Add Serbian localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_sl.properties | Add Slovenian localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_sk.properties | Add Slovak localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_ru.properties | Add Russian localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_pt_PT.properties | Add Portuguese (PT) localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_pt_BR.properties | Add Portuguese (BR) localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_pl.properties | Add Polish localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_nl.properties | Add Dutch localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_nb_NO.properties | Add Norwegian Bokmål localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_lv.properties | Add Latvian localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_lt.properties | Add Lithuanian localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_ko.properties | Add Korean localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_ja.properties | Add Japanese localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_it.properties | Add Italian localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_he.properties | Add Hebrew localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_fr.properties | Add French localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_fi.properties | Add Finnish localization stub for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_es.properties | Add Spanish localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_de.properties | Add German localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_da.properties | Add Danish localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_cs.properties | Add Czech localization for agent overview. |
| core/src/main/resources/jenkins/agent/OverviewTab/index_bg.properties | Add Bulgarian localization for agent overview. |
| core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly | Remove legacy items from sidepanel2 hook. |
| core/src/main/resources/hudson/slaves/SlaveComputer/log.jelly | Convert agent log page to agent-subpage layout. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog.properties | Add disconnect dialog resource bundle (default). |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_zh_TW.properties | Add disconnect dialog Traditional Chinese localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_sv_SE.properties | Add disconnect dialog Swedish localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_sr.properties | Add disconnect dialog Serbian localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_ru.properties | Add disconnect dialog Russian localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_pt_BR.properties | Add disconnect dialog Portuguese (BR) localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_lv.properties | Add disconnect dialog Latvian localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_ja.properties | Add disconnect dialog Japanese localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_it.properties | Add disconnect dialog Italian localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_fr.properties | Add disconnect dialog French localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_es.properties | Add disconnect dialog Spanish localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_de.properties | Add disconnect dialog German localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_da.properties | Add disconnect dialog Danish localization. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnectDialog_bg.properties | Adjust Bulgarian disconnect dialog key naming. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect.properties | Simplify disconnect properties (retain only needed key). |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect.jelly | Convert disconnect page to agent-subpage and dialog include. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_zh_TW.properties | Remove unused legacy disconnect keys for zh_TW. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_sv_SE.properties | Remove unused legacy disconnect keys for sv_SE. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_sr.properties | Remove unused legacy disconnect keys for sr. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_ru.properties | Remove unused legacy disconnect keys for ru. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_pt_BR.properties | Remove unused legacy disconnect keys for pt_BR. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_lv.properties | Remove unused legacy disconnect keys for lv. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_ja.properties | Remove unused legacy disconnect keys for ja. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_it.properties | Remove unused legacy disconnect keys for it. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_fr.properties | Remove unused legacy disconnect keys for fr. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_es.properties | Remove unused legacy disconnect keys for es. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_de.properties | Update German disconnect wording/keys. |
| core/src/main/resources/hudson/slaves/SlaveComputer/disconnect_da.properties | Remove unused legacy disconnect keys for da. |
| core/src/main/resources/hudson/slaves/OfflineCause/LaunchFailed/cause.jelly | Restyle offline causes using alert component + icon. |
| core/src/main/resources/hudson/slaves/OfflineCause/ChannelTermination/cause.jelly | Restyle offline cause message as alert. |
| core/src/main/resources/hudson/slaves/OfflineCause/cause.jelly | Restyle generic offline cause rendering with icons and alert layout. |
| core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly | Simplify description entry wrapper markup. |
| core/src/main/resources/hudson/slaves/ComputerLauncher/app-bar-controls.jelly | Shorten launch/relaunch labels. |
| core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/signup_zh_TW.properties | Remove unused “Show” translation after UI change. |
| core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/signup_pt_BR.properties | Remove unused “Show” translation after UI change. |
| core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/signup_it.properties | Remove unused “Show” translation after UI change. |
| core/src/main/resources/hudson/PluginManager/sidepanel.jelly | Remove sticky side-panel usage in plugin manager. |
| core/src/main/resources/hudson/node_monitors/ResponseTimeMonitor/Data/cause.jelly | Restyle monitor cause as alert. |
| core/src/main/resources/hudson/node_monitors/DiskSpaceMonitorDescriptor/DiskSpace/cause.jelly | Restyle disk space cause as alert. |
| core/src/main/resources/hudson/model/ParametersDefinitionProperty/config-details.jelly | Enable top add button for job parameters list. |
| core/src/main/resources/hudson/model/Messages.properties | Deprecate View.ReadPermission description; add View.ExtendedReadPermission description. |
| core/src/main/resources/hudson/model/Messages_zh_TW.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/Messages_sv_SE.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/Messages_sr.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/Messages_pt_BR.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/Messages_lt.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/Messages_ja.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/Messages_it.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/Messages_es.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/Messages_de.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/Messages_bg.properties | Remove outdated View.ReadPermission translation. |
| core/src/main/resources/hudson/model/LoadStatistics/main.jelly | Hide app-bar in new agent page mode. |
| core/src/main/resources/hudson/model/Job/configure.jelly | Remove sticky side-panel usage in job configure. |
| core/src/main/resources/hudson/model/Computer/sidepanel.jelly | Switch to app-bar actions and adjust box rendering. |
| core/src/main/resources/hudson/model/Computer/setOfflineCause.properties | Fix grammar in offline cause blurb. |
| core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly | Convert setOfflineCause page to agent-subpage layout. |
| core/src/main/resources/hudson/model/Computer/new-agent-page.jelly | Add new agent page entry/bridge jelly. |
| core/src/main/resources/hudson/model/Computer/markOffline.properties | Shorten submit label. |
| core/src/main/resources/hudson/model/Computer/markOffline.jelly | Convert markOffline to agent-subpage layout. |
| core/src/main/resources/hudson/model/Computer/load-statistics.jelly | Convert load statistics to agent-subpage layout. |
| core/src/main/resources/hudson/model/Computer/configure.jelly | Convert agent configure page to agent-subpage layout with new structure. |
| core/src/main/resources/hudson/model/Computer/builds.jelly | Convert build history to agent-subpage layout. |
| core/src/main/resources/hudson/model/Computer/app-controls.properties | Add agent app-controls resource bundle. |
| core/src/main/resources/hudson/model/Computer/_script.jelly | Wrap script console in agent-subpage layout. |
| core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java | Enable app-bar actions for Computers under new agent page flag. |
| core/src/main/java/jenkins/model/menu/action/DeleteAction.java | Add delete action factory for agents. |
| core/src/main/java/jenkins/model/experimentalflags/NewAgentPageUserExperimentalFlag.java | Add user experimental flag for new agent page UI. |
| core/src/main/java/jenkins/model/details/MonitoringDetails.java | Add MonitoringDetails detail type. |
| core/src/main/java/jenkins/core/PluginExcerptSanitizer.java | Add core-internal sanitizer SPI for plugin excerpts. |
| core/src/main/java/jenkins/agent/OverviewTabFactory.java | Provide Overview tab when new agent page flag enabled. |
| core/src/main/java/jenkins/agent/OverviewTab.java | Add Overview tab implementation for agent page. |
| core/src/main/java/jenkins/agent/LogTab.java | Add Log tab implementation for agent page. |
| core/src/main/java/hudson/security/AuthorizationStrategy.java | Remove special-casing for View.READ in view ACL. |
| core/src/main/java/hudson/PluginWrapper.java | Export plugin wrapper fields at visibility=2 for API defaults. |
| core/src/main/java/hudson/model/ViewGroupMixIn.java | Return all views without filtering by View.READ. |
| core/src/main/java/hudson/model/UpdateSite.java | Sanitize plugin excerpt HTML, using core-lib SPI if available. |
| core/src/main/java/hudson/model/Executor.java | Expose pending interrupt status to distinguish abort vs step-thrown InterruptedException. |
| core/src/main/java/hudson/model/AbstractBuild.java | Treat executor-driven InterruptedException as ABORTED during publishers when appropriate. |
| core/src/main/java/hudson/Functions.java | Add helper to expose action event type to Jelly. |
| core/src/main/java/hudson/FilePath.java | Retry rename operation for slow filesystems. |
| core/src/main/java/hudson/cli/handlers/ViewOptionHandler.java | Remove view READ permission enforcement during view resolution. |
| core/src/main/java/hudson/cli/GetViewCommand.java | Require View.EXTENDED_READ for get-view CLI. |
| core-libs/validate-dependencies.groovy | Validate core-libs declared artifacts vs actual dependencies. |
| core-libs/src/main/resources/META-INF/bundled-libraries.properties | Declare core-libs bundled artifact IDs. |
| CONTRIBUTING.md | Document quick-build/test skip implications and frontend skip flag changes. |
| cli/src/test/java/hudson/util/QuotedStringTokenizerTest.java | Add tests clarifying quote overload contract differences. |
| cli/src/main/java/hudson/util/QuotedStringTokenizer.java | Correct documentation for quote(String) behavior. |
| cli/pom.xml | Add compiler annotation processing path; exclude Processor service from shaded jar; add test property. |
| bom/pom.xml | Bump Stapler, commons-codec, sezpoz versions. |
| .idea/encodings.xml | Add IntelliJ encoding entries for core-libs. |
| .gitignore | Ignore generated core-lib directory under war webapp. |
| .github/workflows/changelog.yml | Bump release-drafter action version pin. |
Files not reviewed (1)
- .idea/encodings.xml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+21
| initPasswordVisibilityToggle( | ||
| passwordField, | ||
| document.querySelector("#togglePassword"), | ||
| ); | ||
| initCapsLockIndicator( | ||
| passwordField, | ||
| document.querySelector("#capsLockWarning"), | ||
| ); |
Comment on lines
+2632
to
+2634
| } catch (InterruptedException e) { | ||
| // Ignore | ||
| } |
Comment on lines
316
to
+320
| fetch(context + xmlEscape(opt.event.url), { | ||
| method: "post", | ||
| headers: crumb.wrap({}), | ||
| }).then((rsp) => { | ||
| sessionStorage.setItem( |
Comment on lines
+21
to
+22
| <!-- Intentionally run only one test to reduce cycle time --> | ||
| <test>QuotedStringTokenizerTest</test> |
Comment on lines
+46
to
+48
| public String getUrlName() { | ||
| return null; | ||
| } |
6 tasks
Contributor
Author
|
Closing. Incremental build 2.576-rc38769.2b_6e23248da_0 is being used in BOM pull request: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test several pull requests
Includes pull requests:
Testing done
mvn clean verifypassedScreenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label skip-changelog
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
N/A
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.