More javadoc for RootAction.isPrimary - #10767
Merged
krisstern merged 3 commits intoJul 5, 2025
Merged
Conversation
jtnord
added
developer
daniel-beck
reviewed
Jun 23, 2025
|
|
||
| /** | ||
| * Identifies if the action as a primary action. | ||
| * Primary actions may be handled differently in the UI (for existence by always showing on the header rather than in an actions dropdown). |
Member
There was a problem hiding this comment.
Suggested change
| * Primary actions may be handled differently in the UI (for existence by always showing on the header rather than in an actions dropdown). | |
| * Primary actions may be handled differently in the UI (for example by always showing on the header rather than in an actions dropdown). |
Contributor
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
github-actions
Bot
added
the
unresolved-merge-conflict
jtnord
force-pushed
the
more-javadoc-for-rootAction.isPrimary
branch
from
June 24, 2025 12:18
c7faddc to
39e85a0
Compare
Address review from Jan in jenkinsci#10729 (comment)
jtnord
marked this pull request as ready for review
June 24, 2025 12:20
github-actions
Bot
removed
the
unresolved-merge-conflict
jtnord
commented
Jun 24, 2025
| * As concrete example, an action that provides a Help action with a submenu containing various different links, would be a prime candidate for this to return {@code true}. | ||
| * If your action has the possibility of a {@link #getBadge() badge} then this is another indicator that the action should return {@code true} (or otherwise restructured). | ||
| * @return {@code true} if and only if this action should be considered primary. | ||
| * @since 2.516 |
Member
Author
There was a problem hiding this comment.
upstream change has been merged after 2.515 and before 2.516 so it would be this.
Changed here to avoid leaving a known TODO in the code.
jtnord
commented
Jun 25, 2025
github-actions
Bot
added
the
unresolved-merge-conflict
Contributor
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
github-actions
Bot
removed
the
unresolved-merge-conflict
Contributor
|
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. /label ready-for-merge |
comment-ops-bot
Bot
added
the
ready-for-merge
MarkEWaite
changed the title
krisstern
approved these changes
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the base commit from #10729 to address the comment from @janfaracik
Testing done
Confirmed text renders as expected.
Proposed changelog entries
Proposed changelog category
/label skip-changelog
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).