Skip to content

[JENKINS-75683] Restore transient view actions #10676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 4 commits into from
Jun 9, 2025
Merged

[JENKINS-75683] Restore transient view actions #10676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac39282
Restore view actions
janfaracik May 22, 2025
52fc6f6
Merge branch 'master' into restore-view-actions
janfaracik May 27, 2025
24b0dba
Merge branch 'master' into restore-view-actions
janfaracik Jun 1, 2025
0012e11
Merge branch 'master' into restore-view-actions
janfaracik Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions core/src/main/java/hudson/model/View.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,18 +575,9 @@ public SearchGroup getSearchGroup() {

/**
* Returns the transient {@link Action}s associated with the top page.
*
* <p>
* If views don't want to show top-level actions, this method
* can be overridden to return different objects.
*
* @see Jenkins#getActions()
*/
public List<Action> getActions() {
List<Action> result = new ArrayList<>();
result.addAll(getOwner().getViewActions());
result.addAll(TransientViewActionFactory.createAllFor(this));
return result;
return TransientViewActionFactory.createAllFor(this);
}

/**
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/hudson/model/View/sidepanel.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ THE SOFTWARE.
<st:include page="sidepanel2.jelly" optional="true"/>

<st:include page="tasks-bottom.jelly" it="${it.owner}" optional="true" />
<t:actions />
</l:tasks>
<j:forEach var="w" items="${it.widgets}">
<j:set var="view" value="${it}" /><!-- expose the view that's rendering this sidepanel to the widget -->
Expand Down