Ensure include FilePath in Windows has normalized separators - #306
Open
AbrilRBS wants to merge 2 commits into
Open
Ensure include FilePath in Windows has normalized separators#306AbrilRBS wants to merge 2 commits into
AbrilRBS wants to merge 2 commits into
Conversation
|
Please merge this 🙏 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue and explanation is laid out in #305 (comment)
I'm creating this PR in hopes it helps anyone else facing the same issue.
I understand that the code might might not be fully production ready, or that a better approach might exist, I'd be happy to work towards a better solution after some guidance :)
Closes #305
Testing done
This was tested by running Jenkins with the compiled plugin and validating that a file was in fact uploaded. Before this change, we got a stacktrace when running in Windows. After, we have a file in our bucket. I can provide screenshots of the before/after if needed after some redaction
Submitter checklist