Skip to content

Ensure include FilePath in Windows has normalized separators - #306

Open
AbrilRBS wants to merge 2 commits into
jenkinsci:developfrom
AbrilRBS:rr/fix-windows-issues
Open

Ensure include FilePath in Windows has normalized separators#306
AbrilRBS wants to merge 2 commits into
jenkinsci:developfrom
AbrilRBS:rr/fix-windows-issues

Conversation

@AbrilRBS

@AbrilRBS AbrilRBS commented Jun 24, 2024

Copy link
Copy Markdown

The issue and explanation is laid out in #305 (comment)
I'm creating this PR in hopes it helps anyone else facing the same issue.

I understand that the code might might not be fully production ready, or that a better approach might exist, I'd be happy to work towards a better solution after some guidance :)

Closes #305

Testing done

This was tested by running Jenkins with the compiled plugin and validating that a file was in fact uploaded. Before this change, we got a stacktrace when running in Windows. After, we have a file in our bucket. I can provide screenshots of the before/after if needed after some redaction

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@AbrilRBS
AbrilRBS requested a review from a team as a code owner June 24, 2024 14:29
@joelsdc

joelsdc commented Aug 16, 2025

Copy link
Copy Markdown

Please merge this 🙏 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException when trying to upload file from Windows agent

2 participants