Set the cloud-platform access scope - #281
Open
veram96 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to suggest the use of CLOUD_PLATFORM scope instead of the DEVSTORAGE_FULL_CONTROL scope.
I am facing a problem with Jenkins deployed in GKE and using Workload identity as the authentication method for Jenkins agents where I cannot use this plugin because of the scope requirement.
The suggestion is also motivated by this lines:
"There are many access scopes available to choose from, but a best practice is to set the cloud-platform access scope, which is an OAuth scope for Google Cloud services, and then control the service account's access by granting it IAM roles."
Found in Google documentation
This fixes #231
Testing done
I test the change manually and it seems to fix the problem described.