Remove custom role in favour of Kubernetes Engine Cluster Viewer role - #454
Open
ViliusS wants to merge 1 commit into
Open
Remove custom role in favour of Kubernetes Engine Cluster Viewer role#454ViliusS wants to merge 1 commit into
ViliusS wants to merge 1 commit into
Conversation
Built-in Kubernetes Engine Cluster Viewer role is very minimal and contains all permissions needed to run this plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in Kubernetes Engine Cluster Viewer role is very minimal and contains all permissions needed to run this plugin. This PR removes custom role from documentation and Terraform files, and replaces it with built-in role.
Previous suggested permissions:
New permissions in built-in role:
I think
container.apiServices.*where included by mistake previously. These permissions grant access to Kubernetes level APIServices objects and should be included in RBAC if one really needs to deploy them through plugin.container.clusters.getCredentialswas also not really correct as credentials are generated dynamically, using service account API key. Kubeconfig file is never retrieved or created AFAIK.Testing done
Configured my Service Account to only have new built-in role. Then tested both, Jenkins Declarative Pipeline and Jenkins UI. Plugin works as before.
Submitter checklist