add builds and connection params to UpdateGitlabCommitStatusStep#1911
Open
krisstern wants to merge 3 commits into
Open
add builds and connection params to UpdateGitlabCommitStatusStep#1911krisstern wants to merge 3 commits into
krisstern wants to merge 3 commits into
Conversation
# Conflicts: # src/main/java/com/dabsquared/gitlabjenkins/workflow/UpdateGitLabCommitStatusStep.java
Contributor
There was a problem hiding this comment.
Pull request overview
Adds optional builds and GitLab connection parameters to the updateGitlabCommitStatus Pipeline step so it can update commit status for explicit project/commit targets and/or a chosen connection (intended to improve compatibility with Jenkins Pipeline Shared Libraries).
Changes:
- Add
builds: List<GitLabBranchBuild>parameter toUpdateGitLabCommitStatusStep. - Add
connection: GitLabConnectionPropertyparameter toUpdateGitLabCommitStatusStep. - Minor descriptor annotation and serialization annotation updates.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
89
to
93
| public static class UpdateGitLabCommitStatusStepExecution extends AbstractSynchronousStepExecution<Void> { | ||
| @Serial | ||
| private static final long serialVersionUID = 1; | ||
|
|
||
| private final transient Run<?, ?> run; |
Comment on lines
+75
to
+87
| @DataBoundSetter | ||
| public void setBuilds(List<GitLabBranchBuild> builds) { | ||
| this.builds = builds; | ||
| } | ||
|
|
||
| public GitLabConnectionProperty getConnection() { | ||
| return connection; | ||
| } | ||
|
|
||
| @DataBoundSetter | ||
| public void setConnection(GitLabConnectionProperty connection) { | ||
| this.connection = connection; | ||
| } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To follow up on #1025
Testing done
Ran
mvn clean verifylocallyc.c. @HeikoBoettger-KarlStorz
Submitter checklist