Skip to content

Add choosing strategy with newrev support - #509

Open
ctudor wants to merge 4 commits into
jenkinsci:masterfrom
ctudor:build-chooser-with-merge-commit-support
Open

Add choosing strategy with newrev support#509
ctudor wants to merge 4 commits into
jenkinsci:masterfrom
ctudor:build-chooser-with-merge-commit-support

Conversation

@ctudor

@ctudor ctudor commented May 13, 2024

Copy link
Copy Markdown

This is an update to #440 to build successfully on master. I added the unused field back for now in hopes this will get the code merged into the mainline code.

Testing done

Code has been built and installed locally on our production Jenkins servers with jobs configured to use the new build chooser strategy. I have been maintaining a local fork of changes and have been rebuilding and deploying manually with each new release.

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Charles Tudor added 3 commits May 1, 2024 15:29
Change-Id: Ie19817cc0e8f66d37bda234a2ec744b22f3f569d
Change-Id: If76050183466811870c89228150fb7571f472a6c
@ctudor
ctudor marked this pull request as ready for review May 13, 2024 18:11
@ctudor

ctudor commented Jan 2, 2025

Copy link
Copy Markdown
Author

Any updates on how to get this change merged? Anything else I need to do?

Comment on lines +73 to +77
/**
* Used by XStream for something.
*/
@SuppressWarnings("unused")
private final String separator = "#";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think this is needed.

Suggested change
/**
* Used by XStream for something.
*/
@SuppressWarnings("unused")
private final String separator = "#";

@rsandell

Copy link
Copy Markdown
Member

Well I have been waiting for my original review comments to be addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants