Add choosing strategy with newrev support - #509
Open
ctudor wants to merge 4 commits into
Open
Conversation
added 3 commits
May 1, 2024 15:29
Change-Id: Ie19817cc0e8f66d37bda234a2ec744b22f3f569d
Change-Id: If76050183466811870c89228150fb7571f472a6c
ctudor
marked this pull request as ready for review
May 13, 2024 18:11
Author
|
Any updates on how to get this change merged? Anything else I need to do? |
rsandell
reviewed
Jun 24, 2026
Comment on lines
+73
to
+77
| /** | ||
| * Used by XStream for something. | ||
| */ | ||
| @SuppressWarnings("unused") | ||
| private final String separator = "#"; |
Member
There was a problem hiding this comment.
I still don't think this is needed.
Suggested change
| /** | |
| * Used by XStream for something. | |
| */ | |
| @SuppressWarnings("unused") | |
| private final String separator = "#"; |
Member
|
Well I have been waiting for my original review comments to be addressed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update to #440 to build successfully on master. I added the unused field back for now in hopes this will get the code merged into the mainline code.
Testing done
Code has been built and installed locally on our production Jenkins servers with jobs configured to use the new build chooser strategy. I have been maintaining a local fork of changes and have been rebuilding and deploying manually with each new release.