Skip to content

Query the documentation to check if plugin is enabled #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Query the documentation to check if plugin is enabled #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d179fab
Query the documentation to check if plugin is enabled
deepy Apr 10, 2018
f19bf09
Fixing broken tests.
deepy Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/utils/GerritPluginChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ public static Boolean isPluginEnabled(IGerritHudsonTriggerConfig config, String

CloseableHttpResponse execute = null;
try {
execute = HttpUtils.performHTTPGet(config, restUrl + "plugins/" + pluginName + "/");
execute = HttpUtils.performHTTPGet(config,
restUrl + "plugins/" + pluginName + "/Documentation/index.html");
int statusCode = execute.getStatusLine().getStatusCode();
logger.debug("status code: {}", statusCode);
return decodeStatus(statusCode, pluginName, quiet);
Expand Down
10 changes: 6 additions & 4 deletions ...sonyericsson/hudson/plugins/gerrit/trigger/playback/GerritMissedEventsFunctionalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,12 @@ public void setUp() throws Exception {
server.returnCommandFor(GERRIT_STREAM_EVENTS, SshdServerMock.CommandMock.class);
server.returnCommandFor("gerrit review.*", SshdServerMock.EofCommandMock.class);
server.returnCommandFor("gerrit version", SshdServerMock.EofCommandMock.class);
stubFor(get(urlEqualTo("/plugins/" + GerritMissedEventsPlaybackManager.EVENTS_LOG_PLUGIN_NAME + "/"))
stubFor(get(urlEqualTo("/plugins/" + GerritMissedEventsPlaybackManager.EVENTS_LOG_PLUGIN_NAME +
"/Documentation/index.html"))
.willReturn(aResponse()
.withStatus(HTTPOK)
.withHeader("Content-Type", "text/html")
.withBody("ok")));

}

/**
Expand Down Expand Up @@ -202,7 +202,8 @@ public void testLosePluginSupportedWithEventsAndRestart() throws Exception {
EventTimeSlice lastTimeStamp = gerritServer.getMissedEventsPlaybackManager().getServerTimestamp();

// now we force the plugin is supported to false...
stubFor(get(urlEqualTo("/plugins/" + GerritMissedEventsPlaybackManager.EVENTS_LOG_PLUGIN_NAME + "/"))
stubFor(get(urlEqualTo("/plugins/" + GerritMissedEventsPlaybackManager.EVENTS_LOG_PLUGIN_NAME +
"/Documentation/index.html"))
.willReturn(aResponse()
.withStatus(HTTPERROR)
.withHeader("Content-Type", "text/html")
Expand All @@ -222,7 +223,8 @@ public void testLosePluginSupportedWithEventsAndRestart() throws Exception {
Thread.sleep(SLEEPTIME);

// now we re-enable feature:
stubFor(get(urlEqualTo("/plugins/" + GerritMissedEventsPlaybackManager.EVENTS_LOG_PLUGIN_NAME + "/"))
stubFor(get(urlEqualTo("/plugins/" + GerritMissedEventsPlaybackManager.EVENTS_LOG_PLUGIN_NAME +
"/Documentation/index.html"))
.willReturn(aResponse()
.withStatus(HTTPOK)
.withHeader("Content-Type", "text/html")
Expand Down