Use a dialog to remove servers - #1020
Open
mawinter69 wants to merge 6 commits into
Open
Conversation
Member
|
@mawinter69 Can you rebase this so that I can easier see the actual changes? |
requires jump to 2.568.1 to be able to load the dialog via url
mawinter69
force-pushed
the
remove-dialog
branch
from
July 21, 2026 19:56
7807582 to
ef0482f
Compare
Contributor
Author
|
rebased the change. As the build now requires Java21 it fails early in the Java 17 branch. You would need to retrigger this as owner |
rsandell
approved these changes
Jul 21, 2026
- root action is now in hamburger menu in the header - old style build dirs with datetime instead of build number are no longer supported
Contributor
Author
|
Some tests failed due to going to 2.568.1:
|
Contributor
Author
|
Disabled 2 tests in GerritServerTest that fail due to a problem with htmlunit. See the |
Member
|
It feels a bit iffy to disable tests that tests the very thing you are changing 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires jump to 2.568.1 to be able to load the dialog via url
(built on top of #1018, also includes parts of #1019)
Testing done
Submitter checklist