Skip to content

[WiP] Added and reviewed tests from @kazesberger - #63

Closed
recena wants to merge 2 commits into
jenkinsci:masterfrom
recena:rescue-test
Closed

[WiP] Added and reviewed tests from @kazesberger#63
recena wants to merge 2 commits into
jenkinsci:masterfrom
recena:rescue-test

Conversation

@recena

@recena recena commented Aug 18, 2015

Copy link
Copy Markdown
Contributor

This PR aims to rescue interesting tests from #14 (by @kazesberger). These tests are being reviewing and documented.

@recena recena changed the title Added and reviewed tests from @kazesberger [WiP] Added and reviewed tests from @kazesberger Aug 18, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow. It should be splitted to small test methods. Think now it checks EVERITHING.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanwen Indeed. The PR is [WiP]. I thought to review this kind of things. Anyway, thanks so much.

@jenkinsadmin

Copy link
Copy Markdown
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@oleg-nenashev

Copy link
Copy Markdown
Member

I think it makes sense to extract the test in any case.

@recena , could you please retain the authorship of the original commit? @kazesberger or his company may have strong opinions about it.

@recena

recena commented Aug 19, 2015

Copy link
Copy Markdown
Contributor Author

@oleg-nenashev I don't know what you mean.

@oleg-nenashev

Copy link
Copy Markdown
Member

@recena
Your commit states that the author of the commit is @recena , but the actual author of this code was @kazesberger .

@recena

recena commented Aug 23, 2015

Copy link
Copy Markdown
Contributor Author

@oleg-nenashev I know it. The PR title describes perfectly I'm doing. I did not use his commit because I'm inluding reviews. If you don't agree (once again), please close the PR.

@oleg-nenashev

Copy link
Copy Markdown
Member

I just ask to resubmit changes with the proper author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants