[JENKINS-16316] Changes to global variables not honored. - #20
Merged
Conversation
…to EnvVars.masterEnvVars on slaves.
|
Jenkins » envinject-plugin #104 UNSTABLE |
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
gboissinot
added a commit
that referenced
this pull request
Jul 28, 2013
[JENKINS-16316] Changes to global variables not honored.
Member
Author
|
Could be. Use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to fix JENKINS-16316. When
EnvInjectComputerListener.onOnlineconsidersJenkins.globalNodeProperties, it takes the initial values of these variables and stuffs them intomasterEnvVarson the slave, which really ought to be limited to “natural” environment variables. Then when these variables are changed and a build runs, the old values frommasterEnvVarstake precedence. This is true even if the user has never done anything with the EnvInject plugin except install it—especially insidious.Pull #14 also claims to fix the same bug, in a very different way. Even if that is rejected, its tests may be useful.