Reject illegal characters in new credential IDs#1058
Open
adiprathapa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ID field in the credential forms already warns about illegal characters, but the form can still be submitted and the credential is created anyway. This adds server side validation with Jenkins.checkGoodName at the two interactive creation endpoints, doCreateCredentials in CredentialsStoreAction and doAddCredentials in CredentialsSelectHelper. The popup dialog returns its usual error notification and a plain form submission gets a 400 response.
The XML REST endpoint and the CLI command are left as they are, so credentials exported from an existing instance can still be imported even if their IDs predate this check, in line with the comment about allowing pre stored credentials. Updating and moving existing credentials are also unaffected since the check only runs on creation.
Both new tests fail without the main change and pass with it.
Fixes #977