Skip to content

[JENKINS-62218] Disable Default View select for read-only folder config viewers #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtnord merged 7 commits into from
Aug 3, 2026
Merged

[JENKINS-62218] Disable Default View select for read-only folder config viewers #747

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0bc0fda
JENKINS-62218: Expand Health metrics by default for read-only viewers
Racknaraock Jul 25, 2026
67b5274
JENKINS-62218: Add regression test for read-only health metrics rende…
Racknaraock Jul 25, 2026
c9aed80
JENKINS-62218: Disable Default View select for read-only viewers
Racknaraock Jul 27, 2026
e6eed4f
JENKINS-62218: Propagate readOnlyMode to lazily-loaded tab bar/icon d…
Racknaraock Jul 27, 2026
88edadd
JENKINS-62218: Fix Spotless formatting in FolderTest
Racknaraock Jul 27, 2026
70b6c69
JENKINS-62218: Revert capture=readOnlyMode fix for lazy tab bar/icon …
Racknaraock Jul 27, 2026
853d481
JENKINS-62218: Revert Health metrics f:advanced expansion for read-on…
Racknaraock Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/resources/com/cloudbees/hudson/plugins/folder/AbstractFolder/configure.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ THE SOFTWARE.
<j:if test="${it.folderViews.primaryModifiable and views.size()>1}">
<f:entry title="${%Default View}" field="defaultView">
<div class="jenkins-select">
<select class="jenkins-select__input" name="primaryView">

@jtnord jtnord Jul 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to adapt this to f:select?

@Racknaraock Racknaraock Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo... Choosing f:select would require refactoring the control according to the AJAX-fill model; I decided that this change was better, since it is a pattern already used in the core

https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/views/GlobalDefaultViewConfiguration/config.jelly#L26

<select class="jenkins-select__input" name="primaryView" disabled="${readOnlyMode ? 'true' : null}">
<j:forEach var="v" items="${views}">
<j:choose>
<j:when test="${it.primaryView==v}">
Expand Down