Stops using undeclared commons-lang2

[alecharp]

Description

Commons Lang 2 should be removed from Jenkins Core (jenkinsci/jenkins#26105) but the plugin is using StringUtils from it.

Is required for jenkinsci/bom#6234

Testing done

I could not build the plugin locally, I rely on CI.

Submitter checklist

• Link to JIRA ticket in description, if appropriate.
• Change is code complete and matches issue description
• Appropriate unit or acceptance tests or explanation to why this change has no tests
• Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

• Run the changes and verified the change matches the issue description
• Reviewed the code
• Verified that the appropriate tests have been written or valid explanation given

[mawinter69]

There are many more files that still use commons-lang-2

[alecharp]

I only touch the class in error in the megawar of the bom build. I couldn't build locally the plugin. With the new plugin-pom and the property we should get a complete list.

[mawinter69]

Have you checked that all modules using lang3 have a dependency to the common-lang-3 api plugin? At least transitively over one of the other plugins in this repo?

[alecharp]

Have you checked that all modules using lang3 have a dependency to the common-lang-3 api plugin? At least transitively over one of the other plugins in this repo?

commons-lang3-api is a dependency of commons module. Most of the modules in the repository have a dependency to the module.

• design language doesn't use any class
• blueocean-core-js doesn't not using any class
• blueocean-github-pipeline is using github-api which has a dependency to commons-lang3
• blueocean-bitbucket-pipeline is using cloudbees-bitbucket-branch-source which has a dependency to commons-lang3
• blueocean-jira is using jira (plugin) which has a dependency to commons-lang3

all other modules are using blueocean-commons directly or transitively.

[alecharp]

The maven-enforcer-plugin declaration in blueocean-rest is not compatible with the one in plugin-pom.

@olamy sorry to bother you on this but if you have 5min to point me in the correct direction that would be great.

[olamy]

The maven-enforcer-plugin declaration in blueocean-rest is not compatible with the one in plugin-pom.

@olamy sorry to bother you on this but if you have 5min to point me in the correct direction that would be great.

ok I will have a look. FYI commons-lang2 is declared in root pom as provided ;)

[olamy]

should be a bit better (I hope) with f0cb761
interesting as parent pom has many of those provided dependencies which could be removed (maybe another PR tho)

[alecharp]

Thank you for your help on this!

[olamy]

@alecharp all good to merge and release? Or you do you need something else?

[alecharp]

The build failure on BOM for blueocean doesn't seem to be related to blueocean itself.
IMO it can be merged and released.

[timja]

@alecharp / @olamy what is the plan for this?

Are we able to release it? I know its past CloudBees support but without releasing this BlueOcean will break.

[timja]

@olamy I think the release might have failed. plugins.jenkins.io still reports the old version: https://plugins.jenkins.io/blueocean/

[olamy]

@olamy I think the release might have failed. plugins.jenkins.io still reports the old version: https://plugins.jenkins.io/blueocean/

yup sorry been busy with other tasks. For some reason the buid failed, I changed laptop and so the build needs a special version of node which I do not remember. I will try to figure out...

[olamy]

should be good now.