Fix false positive for @override function parameters - #420
Open
C1-BA-B1-F3 wants to merge 1 commit into
Open
Conversation
When a method uses the @OverRide decorator (from typing or typing_extensions), its parameters should not be flagged as unused since the method signature must match the parent class. Changes: - Add _has_override_decorator() to detect @OverRide, @typing.override, and @typing_extensions.override - Track override state in visit() by saving/restoring _override_depth for function definitions - Skip defining function arguments in visit_arg() when inside an @OverRide function - Inner functions correctly reset the override state (their args are still checked) Fixes jendrikseipp#410
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
==========================================
+ Coverage 93.46% 93.64% +0.18%
==========================================
Files 9 9
Lines 597 614 +17
==========================================
+ Hits 558 575 +17
Misses 39 39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #410
When a method uses the decorator (from or ), its parameters are incorrectly flagged as unused. This PR fixes the false positive by skipping argument definitions for decorated methods.
Changes
Test Cases
Added 6 test cases covering:
All 291 existing tests pass with no regressions.