Skip to content

chore: improve vulture maintenance path - #418

Open
lphuc2250gma wants to merge 1 commit into
jendrikseipp:mainfrom
lphuc2250gma:maint/20260521023350
Open

chore: improve vulture maintenance path#418
lphuc2250gma wants to merge 1 commit into
jendrikseipp:mainfrom
lphuc2250gma:maint/20260521023350

Conversation

@lphuc2250gma

Copy link
Copy Markdown

Summary:

  • Add precise type annotations to the small helper functions in vulture/utils.py (e.g. format_path, condition_is_always_false/true helpers) and add a focused unit test in tests/test_utils.py covering an edge case in format_path (e.g. paths outside cwd, absolute paths on different platforms) — a narrow, mechanical change confined to one small module plus one test file.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.46%. Comparing base (81fb2ac) to head (1c58f88).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #418   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files           9        9           
  Lines         597      597           
=======================================
  Hits          558      558           
  Misses         39       39           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant