Keyboard shortcut failure with small window resize - #890
Open
jandersondbt wants to merge 6 commits into
Open
Conversation
Add keyboard shortcuts for day navigation and today button globally rather than tying them to visible buttons which can be resized and hidden therefore impeding the user of accessing the shortcuts for day navigation when not visible.
Added global keyboard shortcuts for navigation, preview/edit toggle, and find functionality.
Refactor keyboard shortcut handling and clean up comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the left sidebar is resized to hide toolbar buttons (Back, Today, Forward),
the keyboard shortcuts (Ctrl+PageUp, Alt+Home, Ctrl+PageDown) no longer work
because GTK doesn't trigger accelerators for hidden widgets.
Solution
Handle navigation and preview shortcuts directly in the key press event handler
instead of relying solely on button accelerators. This ensures they work
regardless of toolbar visibility.
Testing
Fixes #887