Fix release: the privileged publish job has no checkout to read global.json from - #17
Merged
Merged
Conversation
…loating SDK issues in NuGet verification steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publish-packagejob deliberately runs without a checkout: it is the privileged job that holdsid-token: writefor NuGet Trusted Publishing, so repository content is kept out of it on purpose.Pointing its
setup-dotnetatglobal-json-file: global.jsontherefore asked for a file that does notexist in that job, and the v3.1.0 release failed with:
That step never restores or builds — it only runs
dotnet nuget pushanddotnet nuget verify— so theSDK version cannot influence any
packages.lock.json. It also already pins determinism itself: the nextstep writes an isolated
global.jsonintoRUNNER_TEMPwithrollForward: disableand asserts thatdotnethonours it.So this restores the explicit
dotnet-version: 10.0.xfor that one step and records why it differs fromevery other
setup-dotnetin the repository.The other five
setup-dotnetsteps were audited and all have a checkout earlier in their job:ci.yml(build-and-test, aot-smoke),release.yml(validate),codeql.yml,security.yml.Nothing was published to NuGet by the failed run — 3.1.0 is still absent from nuget.org — so the tag can
be repointed at the merge commit once this lands.