output error messages when downloading vscode server#39
Merged
Conversation
helping the user to recognize/handle issues, see discussion in jeanp413#24
Contributor
Author
|
ping @jeanp413 for review |
Contributor
Author
Owner
|
How does the output log looks after this change? don't think it would be nice if it's polluted with tons of progress lines output |
Contributor
Author
|
In my test this led to 2 additional lines after all the script that is dumped before execution. |
Owner
|
I did some test and I think we can use |
Contributor
Author
|
That's already better than what we currently have (quite), please take that for now, leaving this issue open - I want to check when the printing is updated (likely a TERM setting) and if we can use that - multiple lines are definitely bad.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helping the user to recognize/handle issues, see discussion in #24