Skip to content

output error messages when downloading vscode server#39

Merged
jeanp413 merged 3 commits into
jeanp413:masterfrom
GitMensch:patch-1
Jun 12, 2023
Merged

output error messages when downloading vscode server#39
jeanp413 merged 3 commits into
jeanp413:masterfrom
GitMensch:patch-1

Conversation

@GitMensch

Copy link
Copy Markdown
Contributor

helping the user to recognize/handle issues, see discussion in #24

helping the user to recognize/handle issues, see discussion in jeanp413#24
@GitMensch

Copy link
Copy Markdown
Contributor Author

ping @jeanp413 for review

@GitMensch

GitMensch commented Jun 6, 2023

Copy link
Copy Markdown
Contributor Author

Any comment on this @jeanp413? Note: we may want to give curl preference that would also fix #76 - if wanted I can rebase and do both in one commit.

@jeanp413

jeanp413 commented Jun 9, 2023

Copy link
Copy Markdown
Owner

How does the output log looks after this change? don't think it would be nice if it's polluted with tons of progress lines output

@GitMensch

Copy link
Copy Markdown
Contributor Author

In my test this led to 2 additional lines after all the script that is dumped before execution.
One line showed the download information, the other a progress bar. Is that different on your side?

@jeanp413

Copy link
Copy Markdown
Owner

I did some test and I think we can use --no-verbose for wget and --show-error --silent for curl, sounds good? otherwise I see it prints lots of this lines

 30700K .......... .......... .......... .......... .......... 64%  548M 0s
 30750K .......... .......... .......... .......... .......... 64%  490M 0s
 30800K .......... .......... .......... .......... .......... 64%  368M 0s
 30850K .......... .......... .......... .......... .......... 64%  378M 0s
 30900K .......... .......... .......... .......... .......... 64%  378M 0s
 30950K .......... .......... .......... .......... .......... 65%  526M 0s
 31000K .......... .......... .......... .......... .......... 65%  606M 0s
 31050K .......... .......... .......... .......... .......... 65%  614M 0s
 31100K .......... .......... .......... .......... .......... 65%  516M 0s
 31150K .......... .......... .......... .......... .......... 65%  522M 0s

@GitMensch

GitMensch commented Jun 12, 2023 via email

Copy link
Copy Markdown
Contributor Author

@jeanp413 jeanp413 changed the title output download messages / progress output error messages when downloading vscode server Jun 12, 2023
@jeanp413
jeanp413 merged commit 7689fcd into jeanp413:master Jun 12, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants