fix: fall back to private key when .pub file parsing fails#268
Open
guysoft wants to merge 1 commit into
Open
Conversation
When a .pub file exists but contains a non-SSH key format (e.g. a PGP public key block), the extension would fail to parse it and skip the identity entirely — never attempting to read the actual private key file. This caused pubkey authentication to silently fail with 'Identity keys: None'. Now, if parsing the .pub file returns an error, we fall back to reading and parsing the private key file directly. This matches the behavior of the Microsoft proprietary SSH extension and handles cases where users have non-SSH .pub files in ~/.ssh/. Fixes: jeanp413#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a .pub file exists but contains a non-SSH key format (e.g. a PGP public key block), the extension would fail to parse it and skip the identity entirely — never attempting to read the actual private key file. This caused pubkey authentication to silently fail with 'Identity keys: None'.
Now, if parsing the .pub file returns an error, we fall back to reading and parsing the private key file directly. This matches the behavior of the Microsoft proprietary SSH extension and handles cases where users have non-SSH .pub files in ~/.ssh/.
Fixes: #28