Implement custom remote script support for Linux remotes#132
Implement custom remote script support for Linux remotes#132StarLederer wants to merge 1 commit into
Conversation
|
If this is welcome, we possibly need to document how to write custom scripts or make the default one work the same as custom |
|
Thanks for the PR @StarLederer 🙏 , can we add a extension setting like |
|
I figured using conventional paths would be best for users so they don't have to think how each remote is configured, just whether it explicitly supports open-remote-ssh or not. It is possibly a good idea allow users to override this per host so that their host providers are able to escape the conventional structure if they really need to but I imagine this being more the exception than the rule. As per hard-coded paths vs configurable defaults, I see how in the future the MS extension might also adopt this and use different paths than us but I would add an option to change the default paths only when that happens. I think if users identify missing but expected paths, like something for windows hosts, it is better to add these paths to the extension to help users find the conventional way to organize this and use this extension seamlessly across many remotes. Let me know if you agree. I really like your |
|
@StarLederer Hello, I'm worried about the security implication of a script (outside the extension) to be automatically executed. We should at least prompt the user controlled by a new setting of type |
|
I was thinking of adding something similar, great to see that I'm not the only one thinking of something like this. My idea was to have some sort of install script template that substitutes some of the paths and values expected to be passed. Also, the ability to add pre-install and post-install scripts would be amazing. |
|
I agree some |
|
Oh! I think I did not go through the PR entirely. I was thinking on having those in the host side... |
Yes, it is. |
|
My approach would be a bit different. I would have these as options in the |
Oh, I see. Executing pre-install and post-install scripts when opening the project. They should be in the |
This PR makes it so that server setup scans the remote for known remote installer locations before attempting to use built in scripts.
This allows users to: