Move settings from sidebar to settings menu - #68
Conversation
There was a problem hiding this comment.
I did a quick test drive of this change and I like it! I don't actually know if we want to keep the v2 routing and saved location options -- both were experiments that didn't really pan out, and it might make our lives easier to reduce maintenance burden by stripping them out -- but that doesn't need to happen in this PR, particularly since there's not yet any other features to replace them with.
I'd like to read through the code in more detail before I approve, and I should have time for that on Thursday or Friday.
Makes sense! Saved locations adds an important bit of functionality right now IMO - it lets you generate a route to/from points without an address (e.g. on park paths). This was very useful for me in testing #73. There are other potential ways that could be implemented to get to that outcome, though (and now we support routing to/from coords). |
Move settings from sidebar into a dropdown menu in navbar.
Why? This frees up real estate to put turn-by-turn directions in sidebar on desktop. (I was thinking that on desktop, turn-by-turn directions could start out in the sidebar, and maybe there'd be a button to click to expand them. That would let us show them without altering the rest of the current UI. On mobile, turn-by-turn directions could just be below map.) However, if we don't want to go that direction for the UI of turn-by-turn directions, then this is not needed.
I've removed the search and legend toggle buttons from the desktop view, since they weren't needed there, but left them in the mobile view.
Before
After