chore: bypass mbx for universal macos release builds - #1385
Merged
Conversation
Entire-Checkpoint: 01M1SJ217CHC0QCDKNRHPE9PMK
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe publish workflow now sets ChangesCLI publish workflow
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The universal macOS release build passes both Apple targets to Cargo in one invocation. mbx 1.8.1 rejects this with
managed linker selection supports one Cargo --target per invocation, causing the release build to fail before compilation.Set
MBX_DISABLEfor the universal target so the Cargo shim passes through to native Cargo. Other matrix targets retain mbx.Validation: actionlint, Prettier, and
git diff --checkpass. Verified the bypass behavior in mbx 1.8.1 source; the full signed release build was not run locally.Fixes the failure in https://github.com/jdx/usage/actions/runs/33987850906/job/101364811217.
Note
Low Risk
CI-only conditional env var for one matrix target; no runtime or application code changes.
Overview
Fixes universal macOS release builds that fail when mbx rejects Cargo invocations with more than one
--target(the universalapple-darwinpath passes both architectures in a single build).The
publish-cliworkflow now setsMBX_DISABLEonly for theuniversal-apple-darwinmatrix entry so the Cargo shim falls through to native Cargo for that job. All other release targets keep mbx enabled.Reviewed by Cursor Bugbot for commit ef315d9. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit