fix(schema): align vars shapes with the parser - #12794
Conversation
Entire-Checkpoint: 01M1Q6TQZG3QB0DG8RD4Q5DWQX
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughChangesThe vars schemas now support structured file, path, and source directives; boolean values; encrypted entries; and tools fields constrained to Vars schema validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This updates vars schema validation to accept supported directive forms and reject unsupported configurations, with matching regression coverage. No current merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR aligns the generated configuration schemas with runtime parsing of
Confidence Score: 4/5The schema changes appear safe to merge, with a non-blocking test-coverage gap around newly modeled directive object and mixed-array forms. No behavioral mismatch was established between the changed schemas and runtime parsing; the only finding is that several newly introduced accepted branches lack direct regression coverage. Files Needing Attention: e2e/config/test_schema_tombi Important Files Changed
Reviews (1): Last reviewed commit: "fix(schema): align vars shapes with the ..." | Re-trigger Greptile |
| _.file = { path = ".env", redact = true, required = true, expand = true } | ||
| _.source = ["env.sh"] | ||
| _.path = "./bin" |
There was a problem hiding this comment.
The positive fixture tests an object only for _.file; _.source contains only a string and _.path is scalar. This leaves the newly added object forms for _.path and _.source, along with object entries inside directive arrays, without regression coverage. A schema-generation change that rejects these parser-supported forms could therefore pass this test. Please add positive fixtures for a path or source object and an array containing an option table.
Knowledge Base Used: Testing and end-to-end validation
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 1 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 2 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
Summary
[vars]vars._.file,vars._.path, andvars._.sourcetools = true, which the non-tools vars resolver silently drops[vars.mise]alias and no-op path/source expansionThis is one scope split from #12531. It is independent and based directly on
main; #12793 separately covers the corresponding environment-directive aliases and options.Validation
mise run render:schemamise run test:e2e e2e/config/test_schema_tombiSchema-only change; runtime behavior is unchanged.
AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.