fix(schema): model bootstrap services - #12790
Conversation
Entire-Checkpoint: 01M1Q4Z0R152DDNYGMD4TR6T7C
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe schema adds ChangesSystemd Service Configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This adds validated bootstrap configuration for systemd service state, enablement, masking, and change actions. The schema enforces incompatible masked-service settings, with no current merge-blocking risk identified. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds JSON Schema coverage for system-level bootstrap service declarations.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking schema-hardening issue that allows misspelled service properties to pass validation. The modeled paths, values, defaults, and conditional constraints match the runtime, but omitting Files Needing Attention: schema/mise.json Important Files Changed
Reviews (1): Last reviewed commit: "fix(schema): model bootstrap services" | Re-trigger Greptile |
| "pattern": "^[A-Za-z0-9_.@:][A-Za-z0-9_.@:-]{0,254}$", | ||
| "description": "systemd unit name: at most 255 ASCII letters, digits, '.', '_', '@', ':' or '-', not starting with '-'" | ||
| }, | ||
| "additionalProperties": { |
There was a problem hiding this comment.
Unknown Fields Pass Validation
The per-service object allows arbitrary properties. A typo such as stat = "stopped" therefore passes schema validation, but ServiceTomlConfig silently ignores it and uses the default running state. Add "additionalProperties": false so the schema catches unsupported lifecycle fields.
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 1 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 2 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
Summary
Validation
mise run render:schemaSplit from #12529. This PR is independent and can be reviewed or merged in any order with the sibling bootstrap schema PRs.
Related split
All scopes are independent and target
main; no merge order is required:AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.
Summary by CodeRabbit