chore(release): publish native completions in packslip - #814
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe release workflow replaces ChangesRelease completion assets
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The release workflow now installs completion validation tools through apt and uses system PowerShell for parser validation while continuing to publish all completion assets. No concrete current-head merge-blocking risk is identified. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR publishes native Bash, Zsh, Fish, and PowerShell completion scripts as release assets and signed Packslip resources. It also validates each generated callback and performs shell-specific syntax checks before upload. Changes since the previous review replace the mise-managed PowerShell installation with the hosted runner's existing AI-assisted — Tool: Greptile; model: llmproxy/gpt-5.6-sol; version: unavailable. Confidence Score: 5/5The PR appears safe to merge with no outstanding correctness or repository-rule issues. Both previous findings were manually resolved after the workflow added non-Bash parser checks and initialized mise; the latest revision preserves those checks while using PowerShell already available on the configured hosted runner. Important Files Changed
Reviews (4): Last reviewed commit: "chore(release): harden completion syntax..." | Re-trigger Greptile |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 94dc07c. Configure here.
Instruction countsThe comparison never ran — an earlier step failed.
|
|
The delayed AI-assisted — Tool: Codex; model: OpenAI/GPT-6; version: unavailable. |

Publish native Bash, Zsh, Fish, and PowerShell scripts alongside fnox's usage specification and declare them as signed Packslip completion resources. Installers such as mise can register completions automatically from the release inventory. The scripts call fnox itself and need no separate usage executable.
Release generation checks each script for the native callback, exercises that callback for each shell, and validates Bash syntax. Local generation, callback checks, and Bash/Zsh syntax checks passed with fnox 1.35.1; workflow actionlint/ShellCheck and Prettier passed.
Companion installer support: jdx/mise#12848. Registry adoption: jdx/mise#12845.
AI-assisted — Tool: Codex; model: OpenAI/GPT-6; version: unavailable.
Note
Low Risk
Changes are limited to the release workflow and published assets; no runtime application code, with added CI gates that reduce bad completion scripts shipping.
Overview
Release CI now generates Bash, Zsh, Fish, and PowerShell completion scripts from the Linux release binary (alongside the existing
fnox.usage.kdl), uploads them to the GitHub release, and registers them in the Packslip inventory so installers (e.g. mise) can wire up shell completions from the signed release metadata.The
create-releasejob adds a step to install zsh, fish, and PowerShell on the runner, then validates each completion file (non-empty, includes the__complete_word__hook, and the__complete_word__callback returnsgetforfnox ge) before syntax-checking all four shells. Packslipresourcesgrows fromcli-spec/usageonly to fourcompletion/*asset mappings in addition to the usage spec.Reviewed by Cursor Bugbot for commit 89afdff. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
Bug Fixes