Skip to content

wip: avatar group implement - #177

Open
jingyuexing wants to merge 1 commit into
jd-solanki:mainfrom
jingyuexing:wip-avatarGroup
Open

wip: avatar group implement#177
jingyuexing wants to merge 1 commit into
jd-solanki:mainfrom
jingyuexing:wip-avatarGroup

Conversation

@jingyuexing

Copy link
Copy Markdown

Continuous improvement

@netlify

netlify Bot commented May 18, 2023

Copy link
Copy Markdown

Deploy Preview for anu-vue failed.

Name Link
🔨 Latest commit a2bedbb
🔍 Latest deploy log https://app.netlify.com/sites/anu-vue/deploys/6465d6a5f9ad580008174632

@jd-solanki

Copy link
Copy Markdown
Owner

Hi 👋🏻

At first, I thought we don't need this component but if we think of the future we might need a component for this.

I saw your other PRs and it looks like you don't follow our contribution guide and don't follow our coding pattern. Can you please take a look at it and if possible please update the PR?

Additionally, I recommend you first discuss the API for new component so you don't have to rewrite the code and plan accordingly.

@jingyuexing

Copy link
Copy Markdown
Author

Hi 👋🏻

At first, I thought we don't need this component but if we think of the future we might need a component for this.

I saw your other PRs and it looks like you don't follow our contribution guide and don't follow our coding pattern. Can you please take a look at it and if possible please update the PR?

Additionally, I recommend you first discuss the API for new component so you don't have to rewrite the code and plan accordingly.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants