Conversation
/forceexit against ZX Next Remote ended the session but not the
application, and the far console told the story: every command echoed
except the quit, then 'Connection closed.'. Both servers here answered
the Poll with the goodbye and slammed the socket shut in the same
breath - and ZXNR's listener (before 0.9.52) examined the close first,
discarding the goodbye unread. The dot never showed it because its loop
reads first.
After sending a goodbye ('Q', or the marked exit), both servers now
DRAIN until the peer closes - bounded at 2 s - so the FIN can only ever
follow the goodbye. This fixes the exit for every ZXNR 0.9.47-0.9.51
build in the field without asking anyone to update; the dot closes
within milliseconds of reading 'Q', so the wait is invisible there.
ZXNR 0.9.52 fixes its half too (frames are read before the close
verdict, and a requested exit skips the press-any-key hold).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PC half of ZXNextRemote 0.9.52 (jclauzel/ZXNextRemote#86) — hardware-confirmed together.
/forceexitagainst ZXNR ended the session but not the application, and the far console told the story: every command echoed except the quit, then "Connection closed." Both servers here answered the Poll with the goodbye and slammed the socket shut in the same breath — frame and FIN arriving together over the ESP — and ZXNR's listener (before 0.9.52) examined the close first, discarding the goodbye unread. The dot never showed the bug because its loop reads first.After sending any goodbye (
'Q', or the marked exit), both servers (zxnu_workersandnextsync5) now drain until the peer closes — bounded at 2 s — so the FIN can only ever follow the goodbye. This fixes the exit for every ZXNR 0.9.47–0.9.51 build in the field without an update; the dot closes within milliseconds of reading'Q', so the wait is invisible there.Full suite green (22 files).
🤖 Generated with Claude Code