Skip to content

Set the 'X-RateLimit-Reset' header#5

Open
davebrace wants to merge 1 commit into
jbyck:masterfrom
davebrace:add-ratelimit-reset-header
Open

Set the 'X-RateLimit-Reset' header#5
davebrace wants to merge 1 commit into
jbyck:masterfrom
davebrace:add-ratelimit-reset-header

Conversation

@davebrace

Copy link
Copy Markdown

Set the 'X-RateLimit-Reset' header to the number of seconds until the current throttle expires.

This implements what was proposed here: #2.

The 'X-RateLimit-Reset' header will be set to the number of seconds
until the current throttle expires.
@davebrace
davebrace force-pushed the add-ratelimit-reset-header branch from 88de315 to 954bd04 Compare March 23, 2016 19:55
@pabuisson

Copy link
Copy Markdown

Any news about this PR @davebrace? I'm looking for this kind of feature as well.

@davebrace

Copy link
Copy Markdown
Author

@pabuisson No news - waiting for feedback from the project maintainer @jbyck.

We're using a custom fork of this project in production that includes this feature.

@pabuisson

pabuisson commented Nov 17, 2016

Copy link
Copy Markdown

OK I'm following this PR closely then... and in case it does not merge soon, I'll do the same as you and use a fork of the project. But maybe we'll get some update from @jbyck !

@jbyck

jbyck commented Nov 18, 2016

Copy link
Copy Markdown
Owner

@pabuisson @davebrace sorry for the lack of communication here. I haven't been monitoring this project very well.

This looks reasonable to me, but the tests are failing in Travis. I'll be happy to merge and make a new release once it goes green.

I actually don't use this myself anymore in any current projects - if either of you are using it, and are interested, I'd be happy to pass on ownership for someone to maintain more actively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants