test: add ArchUnit architecture rules and move EXIT_* constants to ExitException#2532
Closed
maxandersen wants to merge 3 commits into
Closed
test: add ArchUnit architecture rules and move EXIT_* constants to ExitException#2532maxandersen wants to merge 3 commits into
maxandersen wants to merge 3 commits into
Conversation
Add EXIT_OK, EXIT_GENERIC_ERROR, EXIT_INVALID_INPUT, EXIT_UNEXPECTED_STATE, EXIT_INTERNAL_ERROR, and EXIT_EXECUTE constants directly to ExitException. BaseCommand now delegates to ExitException for backward compatibility. All non-cli code updated to reference ExitException.EXIT_* instead of BaseCommand.EXIT_*, removing the dependency from domain/util packages onto the CLI layer. Also replaced raw integer literals in ExitException constructor calls with named constants in: TrustedSources, Util, JarUtil, RemoteResourceResolver, NativeBuildStep, CompileBuildStep, Cache, ArtifactResolver, DependencyUtil.
…yering, imports, and exit codes
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
blah - too figgity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the old primitive-options ArchUnit rule (from #2517, no longer needed after #2519) with useful architecture rules that enforce codebase conventions.
Architecture rules added
BaseCommanddev.jbang.cli(exceptExitException)ExitExceptionmust use namedEXIT_*constants, not raw integersEXIT_* constant refactor
Moved
EXIT_OK,EXIT_GENERIC_ERROR,EXIT_INVALID_INPUT,EXIT_UNEXPECTED_STATE,EXIT_INTERNAL_ERROR, andEXIT_EXECUTEfromBaseCommandtoExitException.BaseCommanddelegates for backward compatibility.This enables clean package layering — non-CLI code no longer needs to import
BaseCommandjust for exit code constants. All ~16 raw integer literals innew ExitException(N, ...)replaced with named constants.Why two test approaches?
static final intconstants are inlined into bytecode)