fix: resolve path canonicalization issue in acceptFolder on macOS/Windows

[maxandersen]

On macOS, temp directories resolve through /private/var (e.g. /var/folders/... → /private/var/folders/...) causing jdkFolder.startsWith(jdksRoot) to return false when the jdkFolder path has been resolved via toRealPath() but jdksRoot has not.

This caused LinkedJdk.linked() to fall through to ExternalJdkProvider, producing external-<hash> ids instead of the correct provider id (e.g. 17.0.7-jbang).

Fix

Adds an isUnderRoot() helper in BaseFoldersJdkProvider that falls back to comparing real (canonical) paths when the simple startsWith check fails. The resolved real root path is cached for performance. DefaultJdkProvider.acceptFolder() is updated to use the same helper.

Related

• ci: run tests on ubuntu, macos, and windows #106 — CI: cross-platform test matrix that exposes this failure
• Fix: multi-jdk regression (due to AEsh migration) jbang#2515 — downstream test failures on macOS and Windows caused by this bug

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• ai-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e40f9df4-a507-47cf-99e2-b2c3fab181ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[quintesse]

Helpful but the wrong solution in the end.