Fixed circumventing blocking by appending whitespace to username#248
Merged
kencochrane merged 1 commit intoJul 1, 2025
Merged
Conversation
nrth
force-pushed
the
fix-username-whitespace-block-circumvention
branch
from
July 1, 2025 11:29
9923425 to
29addd2
Compare
Collaborator
|
Thanks, test failed because they were referencing python versions that are end of life'd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appending whitespace to username allows circumventing already blocked usernames (until the 255 char limit is reached), settings used:
The Django admin username/form behaviour automatically strips trailing whitespace (not directly related issue) which allows this to be effective in the first place, I understand that the 255 limit very much counters the attack vector here somewhat, still something that should be considered imo.