Wire @jaywedgeworth22/congress-trading-shared shared package - #112
Wire @jaywedgeworth22/congress-trading-shared shared package#112jaywedgeworth22 wants to merge 1 commit into
Conversation
Replace duplicated types (Chamber, Owner, TxType, SecurityRef, MktCapBucket) with imports from the cross-app shared package. Add contracts.ts barrel re-exporting all shared types, schemas, constants, and utilities. Files changed: - src/shared/types.ts — import Chamber/Owner/TxType from shared - src/enrichment/types.ts — import SecurityRef/MktCapBucket from shared - src/enrichment/compute.ts — import marketCapBucket from shared - src/analytics/compute.ts — import bracketMidpoint from shared - src/analytics/sql.ts — import PartyBucket/WINDOW_PRESETS from shared - src/shared/contracts.ts (new) — barrel re-exports for shared package - package.json — add shared package dep Verification: npx tsc --noEmit — 0 errors Docs: docs/rollouts/2026-06-29-congress-trading-shared.md Co-authored-by: Cursor <cursoragent@cursor.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e99944b. Configure here.
| }, | ||
| "node_modules/@jaywedgeworth22/congress-trading-shared": { | ||
| "version": "1.0.0", | ||
| "resolved": "git+ssh://git@github.com/jaywedgeworth22/congress-trading-shared.git#c34cfae038ee32d8bb3711fc0365f4f6d4ea585b", |
There was a problem hiding this comment.
Lockfile SSH URL breaks CI
Medium Severity
The new shared dependency is pinned with a git+ssh:// resolved URL in the lockfile. npm ci clones exactly that URL, so installs on GitHub Actions and other hosts without GitHub SSH keys often fail before typecheck or tests run.
Reviewed by Cursor Bugbot for commit e99944b. Configure here.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e99944bad7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "node_modules/@jaywedgeworth22/congress-trading-shared": { | ||
| "version": "1.0.0", | ||
| "resolved": "git+ssh://git@github.com/jaywedgeworth22/congress-trading-shared.git#c34cfae038ee32d8bb3711fc0365f4f6d4ea585b", |
There was a problem hiding this comment.
In environments that run a fresh npm ci without GitHub SSH credentials, this lockfile entry makes npm fetch the new shared package via git+ssh://git@github.com/...; GitHub does not allow anonymous SSH, so CI/dev bootstrap/deploy installs fail before typecheck or tests can run. Please lock this dependency to an HTTPS URL or a published package version that the standard install path can fetch.
Useful? React with 👍 / 👎.
1 participant
Replace duplicated types (Chamber, Owner, TxType, SecurityRef, MktCapBucket) with imports from the cross-app shared package. Add contracts.ts barrel re-exporting all shared types, schemas, constants, and utilities.
Files changed
app/src/shared/types.ts— import Chamber/Owner/TxType from sharedapp/src/enrichment/types.ts— import SecurityRef/MktCapBucket from sharedapp/src/enrichment/compute.ts— import marketCapBucket from sharedapp/src/analytics/compute.ts— import bracketMidpoint from sharedapp/src/analytics/sql.ts— import PartyBucket/WINDOW_PRESETS from sharedapp/src/shared/contracts.ts(new) — barrel re-exports for shared packageapp/package.json— add shared package depVerification
npx tsc --noEmit: 0 errorsShared package
See jaywedgeworth22/congress-trading-shared
Made with Cursor