Skip to content

Respect output.filename config option#3

Open
kayakyakr wants to merge 1 commit into
jaydenseric:masterfrom
kayakyakr:config-filename
Open

Respect output.filename config option#3
kayakyakr wants to merge 1 commit into
jaydenseric:masterfrom
kayakyakr:config-filename

Conversation

@kayakyakr

Copy link
Copy Markdown
Contributor

Fixes #2

@benbender

Copy link
Copy Markdown

Just as a note: it's not that easy, because webpack accepts placeholders as the filename option.
F.e. this is valid in webpack:

options.filename = '[name].js';

In this case, your change will not be able to find the filename to start.

@kayakyakr

Copy link
Copy Markdown
Contributor Author

Yeah, that's a good point, but the systems using the templated filename won't work in the current setup anyway, so you're not losing anything.

Will have to determine if it's possible to parse those templates to discover the file.

@kayakyakr

Copy link
Copy Markdown
Contributor Author

Yeah, just reiterating the point that options.filename = '[name].js' won't work with the current setup anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants