Repository navigation
Fix unclosed script tag for injected JavaScript in Swagger UI - #286
Merged
dzikoysk merged 1 commit intoSep 21, 2026
Merged
Conversation
dzikoysk
approved these changes
Sep 21, 2026
Member
|
Sorry for a late response, I just came back from holidays 🌴 Nice catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried injecting a custom JS file with
injectJavaScriptbut it never ran, and I found that it was because the tag is rendered as self-closing<script src='/script.js' type='text/javascript' />.The fix was to change it to
<script src='/script.js' type='text/javascript'></script>.Updated
SwaggerPluginTestcase to assert the closed form.I also verified locally that an injected script now executes.