Sonarqube integration - correction of transfered data

.sonarlint/connectedMode.json

@@ -0,0 +1,5 @@
+{
+    "sonarCloudOrganization": "java-helpers",
+    "projectKey": "java-helpers_simple-builders",
+    "region": "EU"
+}

README.md

@@ -5,6 +5,8 @@
 [![Java Version](https://img.shields.io/badge/Java-17%2B-blue)](https://www.oracle.com/java/technologies/javase/17-relnote-issues.html)
 [![Maven](https://img.shields.io/badge/Maven-3.8%2B-orange)](https://maven.apache.org/)
 [![codecov](https://codecov.io/gh/java-helpers/simple-builders/graph/badge.svg)](https://codecov.io/gh/java-helpers/simple-builders)
+[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=java-helpers_simple-builders&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=java-helpers_simple-builders)
+[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=java-helpers_simple-builders&metric=sqale_rating)](https://sonarcloud.io/summary/new_code?id=java-helpers_simple-builders)
 
 ## Table of Contents
 - [What is Simple Builders?](#what-is-simple-builders)

core/src/main/java/org/javahelpers/simple/builders/core/builders/HashSetBuilder.java

@@ -67,6 +67,6 @@ public HashSetBuilder<T> addAll(Set<T> elements) {
    * @return a new HashSet containing all elements added to this builder
    */
   public Set<T> build() {
-    return new HashSet(mSet);
+    return new HashSet<>(mSet);
   }
 }

processor/src/main/java/org/javahelpers/simple/builders/processor/BuilderProcessor.java

@@ -29,21 +29,18 @@
 import com.google.auto.service.AutoService;
 import java.util.Set;
 import javax.annotation.processing.AbstractProcessor;
-import javax.annotation.processing.Filer;
-import javax.annotation.processing.Messager;
 import javax.annotation.processing.ProcessingEnvironment;
 import javax.annotation.processing.Processor;
 import javax.annotation.processing.RoundEnvironment;
 import javax.annotation.processing.SupportedAnnotationTypes;
 import javax.lang.model.SourceVersion;
 import javax.lang.model.element.Element;
 import javax.lang.model.element.TypeElement;
-import javax.lang.model.util.Elements;
-import javax.lang.model.util.Types;
-import javax.tools.Diagnostic;
 import org.javahelpers.simple.builders.processor.dtos.BuilderDefinitionDto;
 import org.javahelpers.simple.builders.processor.exceptions.BuilderException;
 import org.javahelpers.simple.builders.processor.util.JavaCodeGenerator;
+import org.javahelpers.simple.builders.processor.util.ProcessingContext;
+import org.javahelpers.simple.builders.processor.util.ProcessingLogger;
 
 /**
  * BuilderProcessor is an annotation processor for execution in generate-sources phase. The
@@ -53,30 +50,26 @@
 @AutoService(Processor.class)
 @SupportedAnnotationTypes("org.javahelpers.simple.builders.core.annotations.SimpleBuilder")
 public class BuilderProcessor extends AbstractProcessor {
-  private Types typeUtils;
-  private Elements elementUtils;
-  private Filer filer;
-  private Messager messager;
+  private ProcessingContext context;
   private JavaCodeGenerator codeGenerator;
   private boolean supportedJdk = true;
 
   @Override
   public synchronized void init(ProcessingEnvironment processingEnv) {
     super.init(processingEnv);
-    this.typeUtils = processingEnv.getTypeUtils();
-    this.elementUtils = processingEnv.getElementUtils();
-    this.filer = processingEnv.getFiler();
-    this.messager = processingEnv.getMessager();
-    this.codeGenerator = new JavaCodeGenerator(filer);
+    ProcessingLogger logger = new ProcessingLogger(processingEnv.getMessager());
+    this.context =
+        new ProcessingContext(
+            processingEnv.getElementUtils(), processingEnv.getTypeUtils(), logger);
+    this.codeGenerator = new JavaCodeGenerator(processingEnv.getFiler());
 
     // Enforce minimum Java version (17+) for the processor
     SourceVersion current = processingEnv.getSourceVersion();
     this.supportedJdk = isAtLeastJava17(current);
     if (!this.supportedJdk) {
-      messager.printMessage(
-          Diagnostic.Kind.ERROR,
+      context.error(
           "simple-builders requires Java 17 or higher for annotation processing. Detected: "
-              + String.valueOf(current)
+              + current
               + ". Please upgrade to JDK 17+ or disable the processor.");
     }
   }
@@ -85,24 +78,24 @@ public synchronized void init(ProcessingEnvironment processingEnv) {
   public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
     if (!supportedJdk) {
       // Fail fast: we already emitted an error in init(); do not attempt any processing.
-      return true;
+      return false;
     }
     // Resolve annotation as TypeElement to support environments where the Class<?> overload
     // of getElementsAnnotatedWith is unavailable.
     TypeElement simpleBuilderAnnotation =
-        elementUtils.getTypeElement(
+        context.getTypeElement(
             org.javahelpers.simple.builders.core.annotations.SimpleBuilder.class
                 .getCanonicalName());
     if (simpleBuilderAnnotation == null) {
-      // TODO: Logging
-      // Annotation type not on classpath; nothing to do this round.
-      return true;
+      context.error(
+          "Annotation org.javahelpers.simple.builders.core.annotations.SimpleBuilder is not on classpath. So nothing to do here.");
+      return false;
     }
     for (Element annotatedElement : roundEnv.getElementsAnnotatedWith(simpleBuilderAnnotation)) {
       try {
         process(annotatedElement);
       } catch (BuilderException ex) {
-        // TODO Logging
+        context.error(annotatedElement, "Failed to process annotated element: " + ex.getMessage());
       }
     }
     return true;
@@ -114,7 +107,7 @@ public SourceVersion getSupportedSourceVersion() {
   }
 
   private void process(Element annotatedElement) throws BuilderException {
-    BuilderDefinitionDto builderDef = extractFromElement(annotatedElement, elementUtils, typeUtils);
+    BuilderDefinitionDto builderDef = extractFromElement(annotatedElement, context);
     codeGenerator.generateBuilder(builderDef);
   }
 

processor/src/main/java/org/javahelpers/simple/builders/processor/dtos/MethodCodeDto.java

@@ -33,7 +33,7 @@ public class MethodCodeDto {
   private String codeFormat;
 
   /** List of placeholders in CodeFormat. Containing dynamic values too. */
-  private final List<MethodCodePlaceholder> codeArguments = new ArrayList<>();
+  private final List<MethodCodePlaceholder<?>> codeArguments = new ArrayList<>();
 
   /**
    * Setting format of code.
@@ -78,7 +78,8 @@ public String getCodeFormat() {
    *
    * @return argument values
    */
-  public List<MethodCodePlaceholder> getCodeArguments() {
+  @SuppressWarnings("java:S1452")
+  public List<MethodCodePlaceholder<?>> getCodeArguments() {
     return codeArguments;
   }
 }

processor/src/main/java/org/javahelpers/simple/builders/processor/dtos/MethodCodePlaceholder.java

@@ -39,7 +39,7 @@ public abstract class MethodCodePlaceholder<T> {
    * @param label name of placeholder
    * @param value dynamic value for placeholder
    */
-  public MethodCodePlaceholder(String label, T value) {
+  protected MethodCodePlaceholder(String label, T value) {
     this.label = label;
     this.value = value;
   }

processor/src/main/java/org/javahelpers/simple/builders/processor/exceptions/BuilderException.java

@@ -28,7 +28,7 @@
 
 /** Special exception for errors in processing of annotations. */
 public class BuilderException extends Exception {
-  private final Element element;
+  private final transient Element element;
 
   /**
    * Creating an exception with location element, message and parameters.