Repository navigation
feat: rename setterSuffix option to setterPrefix (#342) - #344
Merged
AndreasIgel merged 3 commits intoOct 12, 2026
Merged
AndreasIgel merged 3 commits into
AndreasIgel merged 3 commits into
Conversation
The option was applied as a prefix (setterSuffix + capitalize(field)), never a suffix. Hard rename across the annotation element, BuilderConfiguration, the -Asimplebuilder.setterPrefix compiler arg and docs, with no compatibility alias.
AndreasIgel
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…tter-prefix-rename # Conflicts: # processor/src/main/java/org/javahelpers/simple/builders/processor/generators/util/MethodGeneratorUtil.java
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #342.
Why
setterSuffixwas applied as a prefix —MethodGeneratorUtil.generateBuilderMethodNameproducessetterSuffix + capitalize(fieldName)— never a suffix. The misleading name already caused a real bug in #312.What
Hard rename with no compatibility alias, per the issue decision:
@SimpleBuilder.Options#setterSuffix()→setterPrefix()BuilderConfigurationrecord component, builder method andgetSetterSuffix()→getSetterPrefix()CompilerArgumentsEnum.SETTER_SUFFIX→SETTER_PREFIX, compiler arg-Asimplebuilder.setterSuffix→-Asimplebuilder.setterPrefixdocs/CONFIGURATION.mdand javadoc updated to prefix semanticsExisting user configs fail loudly on the unknown option, as intended.
Verified
mvn clean verify— all modules passsetter.?suffixreference remains (case-insensitive repo-wide grep)