Repository navigation
Exclude bot-authored PRs from Sonar/Codecov secret steps - #207
Merged
AndreasIgel merged 1 commit intoJul 20, 2026
Merged
AndreasIgel merged 1 commit into
AndreasIgel merged 1 commit into
Conversation
Co-Authored-By: Andreas Igel <andreas.igel@computacenter.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the
Java CI with Mavensecret-bearing steps so they never run automatically for bot-authored PRs, using a generic account-type check instead of secret-emptiness or a hard-coded bot login.Fixes #206
Before, the steps gated only on secret availability:
That is not robust: when a maintainer re-runs a Dependabot PR's jobs, secrets become available and the
SonarCloud Analysisstep executes (observed on #205: it ran and failed withHTTP 403 ... check SONAR_TOKEN). Matchinggithub.actor != 'dependabot[bot]'is equally brittle — one exact name, misses other bots.Now each secret step also requires the PR author to not be a bot:
pushtomain: no PR context →user.typeis''→ runs (unchanged).user.type == 'User'→ runs.user.type == 'Bot'→ skipped, even on a maintainer re-run.fork-coverage/fork-sonarworkflows.Validation
actionlintpasses.