Repository navigation

#141 Removing builder specifics from CodeGenerator - #144

Merged

AndreasIgel merged 30 commits into

mainfrom

feature/141-removing-builder-specifics-from-codegenerator

Apr 23, 2026

Merged

#141 Removing builder specifics from CodeGenerator#144
AndreasIgel merged 30 commits into
mainfrom
feature/141-removing-builder-specifics-from-codegenerator

AndreasIgel commented Apr 6, 2026

Collaborator

solves #141

AndreasIgel added 5 commits

April 4, 2026 11:21


          Renaming BuilderDefinitionDto to GenerationTargetClassDto for general…

1eb58be

…isation


          Fixing expectations because primitive types do not need a null check …

4c1bf84

…when being taken via getters


          1st state of refactoring to have a GenerationTargetClassDto and a bui…

ac1e8e2

…lder independent RoasterCodeGenerator


          Fixing failing tests

1fd07e0


          Switching from javax Modifier to AccessModifier

9c37416

github-actions Bot commented Apr 6, 2026 •

edited

Loading

Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 477d928.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

codecov Bot commented Apr 6, 2026 •

edited

Loading

Codecov Report

❌ Patch coverage is 95.08671% with 17 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...imple/builders/processor/util/ImportCollector.java	89.79%	3 Missing and 7 partials ⚠️
...rs/simple/builders/processor/BuilderProcessor.java	75.00%	3 Missing ⚠️
...ocessor/classgen/roaster/RoasterCodeGenerator.java	97.50%	1 Missing and 1 partial ⚠️
...ers/simple/builders/core/enums/AccessModifier.java	0.00%	1 Missing ⚠️
...essor/generators/field/VarArgsHelperGenerator.java	88.88%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...in/java/org/javahelpers/simple/builders/processor/classgen/roaster/RoasterCodeGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...n/java/org/javahelpers/simple/builders/processor/generators/builder/ConstructorEnhancer.java Resolved

AndreasIgel commented

View reviewed changes

...n/java/org/javahelpers/simple/builders/processor/generators/builder/ConstructorEnhancer.java Resolved

AndreasIgel commented

View reviewed changes

...n/java/org/javahelpers/simple/builders/processor/generators/builder/ConstructorEnhancer.java Resolved

AndreasIgel commented

View reviewed changes

...n/java/org/javahelpers/simple/builders/processor/generators/builder/ConstructorEnhancer.java Resolved

AndreasIgel commented

View reviewed changes

...n/java/org/javahelpers/simple/builders/processor/generators/builder/ConstructorEnhancer.java Resolved

AndreasIgel commented

View reviewed changes

...n/java/org/javahelpers/simple/builders/processor/generators/builder/CoreMethodsEnhancer.java Resolved

AndreasIgel commented

View reviewed changes

...ava/org/javahelpers/simple/builders/processor/generators/field/AddToCollectionGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...ava/org/javahelpers/simple/builders/processor/generators/field/AddToCollectionGenerator.java Resolved

AndreasIgel commented

View reviewed changes

...main/java/org/javahelpers/simple/builders/processor/generators/util/MethodGeneratorUtil.java Resolved

AndreasIgel commented

View reviewed changes

...src/main/java/org/javahelpers/simple/builders/processor/model/core/BuilderDefinitionDto.java Resolved

AndreasIgel commented

View reviewed changes

processor/src/main/java/org/javahelpers/simple/builders/processor/model/core/ClassFieldDto.java Resolved

AndreasIgel commented

View reviewed changes

processor/src/main/java/org/javahelpers/simple/builders/processor/model/core/ClassFieldDto.java Resolved

AndreasIgel commented

View reviewed changes

processor/src/test/java/org/javahelpers/simple/builders/processor/BuilderProcessorTest.java Resolved

AndreasIgel commented

View reviewed changes

AndreasIgel left a comment

Collaborator Author

Review done

AndreasIgel added 25 commits

April 11, 2026 23:51


          Improving code quality

9290bdb


          Reintegration of protected enum value for accessModifier

1e8e096


          Removed unneeded switch and boxing

207aad5


          Adding toString to ClassFieldDto and ConstructorDto

95ad771


          Improving codequality

9fe1d9f


          Replacing usage of named Types by referencing the class

104bc5e


          Improving codequality

3de08d5


          Setting visibility of fields on Private per default

dce5ca1


          Improving handling of codeBlockImports in context of constructorDto a…

c55c636

…nd MethodDto


          Switching import-collecting and sorting into a helper class

6473fca


          Fixing issue of missing NonNull import in testclasses

9cd014d


          Implementation of ImportStatement dto to handle static and regular im…

b95baab

…ports


          Adepting test-expectation of full generation

4edc00f


          Adapting handling of imports - GenericTypes should not get directly i…

dc6bd45

…mports


          Fixing codesmells from SonarQube

b86e80d


          separation of imports because of field type and specific field-imports

8863f3f


          Removing unused functions

06228e0


          Removing unneeded coreMethods field

710b66a


          Removing sourceDescription from methodDto because it is only needed f…

3fa5ce1

…or logging in conflict resolution


          Switching interfaces visibility to use AccessModifier

8df92b5


          Using flat-map-streams for import collecting

dfe8996


          Migration generation of JacksonModule into default functionality of R…

8d157bf

…oasterCodeGenerator (to have no specific code there anymore)


          Removing unneeded JacksonModuleDefinitionDto


          Improving code

9a673b5


          Removing unused private helper function

477d928

sonarqubecloud Bot commented Apr 23, 2026

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

AndreasIgel merged commit 076a093 into main

8 checks passed

AndreasIgel deleted the feature/141-removing-builder-specifics-from-codegenerator branch

April 23, 2026 20:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet