refactor(posts): model idempotency keys as a domain value - #1217
Merged
Conversation
mdorman
commented
Aug 27, 2026
| .and_then(|v| v.to_str().ok()) | ||
| .map(str::trim) | ||
| .filter(|s| !s.is_empty()); | ||
| .and_then(|value| value.to_str().ok()?.parse::<IdempotencyKey>().ok()); |
Contributor
Author
There was a problem hiding this comment.
Why isn't this a method on IdempotencyKey itself, something like fromHeaders?
Contributor
Author
There was a problem hiding this comment.
Extracted this as idempotency_key_from_headers in 2d7b471. I kept it at the AtomPub adapter seam rather than making it an inherent IdempotencyKey method: missing-header and HeaderValue::to_str rejection are HTTP compatibility policy, while the common domain type intentionally has no http/Axum dependency and owns only trim/non-empty canonicalization. The handler now names the whole boundary policy in one call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IdempotencyKeydomain type with validating serde/SQLx supportVerification
cargo xtask test-local -- -p common idempotency_keycargo xtask test-local -- idempotencycargo xtask checkCloses #1086