Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -1306,7 +1306,7 @@ permalink, or `Username`—and add no generic string, `Debug`, or `Display`
fallback. Authors still write `skip(…)` / `skip_all` as explicit opt-outs.
`server-fn-tracing` now checks source grammar, skip names, pattern-bound
parameters, and declaration-only fields, but classifies no type names
([sink-specific telemetry interfaces](adr/drafts/sink-specific-telemetry-interfaces.md)).
([sink-specific telemetry interfaces](adr/0154-sink-specific-telemetry-interfaces.md)).

Wire parse errors likewise own their sink projections: `user_message` selects
feedback for the submitter and `telemetry_code` supplies a bounded
Expand Down
1 change: 1 addition & 0 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ convention). See the Status column below for each ADR's current status.
| [0151](adr/0151-subscriber-reference-invariant.md) | Subscriber references are non-blank validated identities | accepted |
| [0152](adr/0152-adr-numbering-happens-after-merge.md) | ADR numbering happens after feature merge | accepted |
| [0153](adr/0153-storage-owned-instants.md) | Storage-owned instants use UtcInstant | accepted |
| [0154](adr/0154-sink-specific-telemetry-interfaces.md) | Sink-Specific Telemetry Interfaces | accepted |

<!-- adr-table:end -->

Expand Down
2 changes: 1 addition & 1 deletion docs/adr/0011-unified-observability.md
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ the convention became a gate: `server-fn-tracing`, in `cargo xtask check` and
> 2026-08-25, `RECORDABLE_TYPES` no longer held the four admission grounds.
> Type-owned `TraceField` projections and compiler trait resolution held them
> instead; the grounds and exclusions below were unchanged. The replacement
> decision is `docs/adr/drafts/sink-specific-telemetry-interfaces.md`.
> decision is `docs/adr/0154-sink-specific-telemetry-interfaces.md`.

### The span (as of 2026-07-29)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# ADR-DRAFT: Sink-Specific Telemetry Interfaces
# ADR-0154: Sink-Specific Telemetry Interfaces

- Status: proposed
- Status: accepted
- Date: 2026-08-25
- Issue: [#1138](https://github.com/jaunder-org/jaunder/issues/1138)

## Context

[ADR-0011](../0011-unified-observability.md) admitted server-function parameter
[ADR-0011](0011-unified-observability.md) admitted server-function parameter
values to tracing on four grounds: intrinsically bounded values, operator
configuration, already-public permalink values, and `Username`. The
`server-fn-tracing` gate stored that decision as `RECORDABLE_TYPES`, reducing
Expand Down Expand Up @@ -44,7 +44,7 @@ declaration-only-field checks, but performs no type-name classification.
The four admission grounds and exclusions from ADR-0011 remain unchanged.
Secrets, email, arbitrary content, request aggregates, and the existing skipped
parameters gain no tracing interface.
[ADR-0147](../0147-decision-path-observability.md) still permits decision-path
[ADR-0147](0147-decision-path-observability.md) still permits decision-path
fields only as `tracing::field::Empty` declarations recorded later by the span
owner. Rejecting value expressions plus the generated parameter `skip_all`
prevents those declarations from bypassing `TraceField`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Out:

- [x] Task 5: Project and certify the policy replacement
- Contract: add tracked draft
`docs/adr/drafts/sink-specific-telemetry-interfaces.md` with the canonical
`docs/adr/0154-sink-specific-telemetry-interfaces.md` with the canonical
`# ADR-DRAFT` heading and `Status: proposed`. It supersedes ADR-0011's
`RECORDABLE_TYPES` mechanism while retaining the four admission grounds and
accounting for ADR-0147. Add only a reciprocal past-tense navigation
Expand Down