Code Review and Acceralation#1
Open
Benedict-Y wants to merge 9 commits into
Open
Conversation
| self.similarity_matrix = similarity.cpu().numpy() | ||
|
|
||
| # 确保对角线上是1.0（自己与自己的相似度） | ||
| np.fill_diagonal(self.similarity_matrix, 1.0) |
There was a problem hiding this comment.
The code uses 'np.fill_diagonal' but there is no corresponding import for numpy. Please add 'import numpy as np' at the top of the file.
Collaborator
Author
There was a problem hiding this comment.
Actually we have added
There was a problem hiding this comment.
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (1)
- data/ml-1m/README: Language not supported
Comments suppressed due to low confidence (1)
src/models/user_cf.py:88
- The code uses 'np' (numpy) but numpy is not imported. Please add 'import numpy as np' at the top of the file to avoid runtime errors.
self.similarity_matrix = np.zeros((n_users, n_users))
Benedict-Y
commented
Apr 5, 2025
| self.similarity_matrix = similarity.cpu().numpy() | ||
|
|
||
| # 确保对角线上是1.0（自己与自己的相似度） | ||
| np.fill_diagonal(self.similarity_matrix, 1.0) |
Collaborator
Author
There was a problem hiding this comment.
Actually we have added
later will upload the final report
Update the final report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
删除了一些main冗余的注释。然后改了SVD，加速运行。改了评估，加速运行，改了一些小的导入包的问题