MNLFA: reduce redundant TabView model resets - #404
Open
juliuspfadt wants to merge 7 commits into
Open
Conversation
Third-layer values now depend on cached factorCount int, not factorsTitles array -> no reset on rename/indicator changes. Complements jasp-desktop TabView height fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* Translated using Weblate (Japanese) Currently translated at 100.0% (582 of 582 strings) Translation: JASP/jaspSem-QML Translate-URL: https://hosted.weblate.org/projects/jasp/jaspsem-qml/ja/ * Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 100.0% (582 of 582 strings) Translation: JASP/jaspSem-QML Translate-URL: https://hosted.weblate.org/projects/jasp/jaspsem-qml/zh_Hant/ --------- Co-authored-by: Koji Kosugi <kosugitti@gmail.com> Co-authored-by: 陳正昌 <chencc99@gmail.com>
* Translated using Weblate (German) Currently translated at 55.0% (227 of 412 strings) Translation: JASP/jaspSem-R Translate-URL: https://hosted.weblate.org/projects/jasp/jaspsem-r/de/ * Translated using Weblate (Japanese) Currently translated at 100.0% (412 of 412 strings) Translation: JASP/jaspSem-R Translate-URL: https://hosted.weblate.org/projects/jasp/jaspsem-r/ja/ --------- Co-authored-by: Johannes Keyser <joke@fsfe.org> Co-authored-by: Koji Kosugi <kosugitti@gmail.com>
Thurstone stays default. Bartlett is univocal with >1 factor. Both validated against OpenMx where it is correct; neither recovers the inter-factor correlation, noted in the help text. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MNLFA hardening: third-layer TabView
values:now depend on a cachedfactorCountint property instead of thefactorsTitlesarray, so tab models only reset when the factor count changes — not on every rename/indicator change.Why
The nested TabViews in MNLFA intermittently collapse to zero height. Root cause is a stale height binding in jasp-desktop's TabView after model resets — fixed in jasp-stats/jasp-desktop#6295. This PR complements it by removing redundant reset triggers on the module side.
No option
name:changes → no Upgrades.qml migration. All 12 MNLFA tests pass.🤖 Generated with Claude Code