fix time calculation after a blur event - #77
Open
zvictor wants to merge 2 commits into
Open
Conversation
This was referenced Nov 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As reported at #41 and #59, TimeMe has a hard time to notice user activity after a blur event is triggered by activity on an iframe, such as Youtube/Vimeo embeds.
Diagnosis
This happens because the user can be navigating again on the parent page (scroll, mousemove, etc) even though the focus remains on the iframe. That won't change unless the user decides to click somewhere in the parent page.
Solution
In order to fix that, we need to start tracking time again as soon as the user shows activity on the parent page. TimeMe has to call
TimeMe.triggerUserHasReturnedwhenever there is activity showing that the user has returned:as such: