Skip to content

Add more effects: reverb, chorus, autowah, delay #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jasongwartz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add more effects: reverb, chorus, autowah, delay #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/ostinato/effect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ interface EffectNameToNodeType {
lpf: Tone.Filter
gain: Tone.Gain
volume: Tone.Volume
reverb: Tone.Reverb
chorus: Tone.Chorus
autowah: Tone.AutoWah
delay: Tone.Delay
}

interface NodeWithProperties<T> {
Expand Down Expand Up @@ -63,6 +67,36 @@ const nodeCreators: NodeCreator = {
update: (node, value) => (node.volume.value = value),
connect: (source, node) => source.connect(node.volume),
},
reverb: {
default: 1.5, // Tone.js reverb default value
min: 0,
max: 10,
create: () => new Tone.Reverb(),
update: (node, value) => (node.decay = value),
},
chorus: {
default: 1.5, // Tone.js default value
min: 0,
max: 10,
create: () => new Tone.Chorus(),
update: (node, value) => (node.frequency.value = value),
connect: (source, node) => source.connect(node.frequency),
},
autowah: {
default: 100, // Tone.js default value
min: 0,
max: 1000,
create: () => new Tone.AutoWah(),
update: (node, value) => (node.baseFrequency = value),
},
delay: {
default: 1,
min: 0,
max: 20,
create: () => new Tone.Delay(),
update: (node, value) => (node.delayTime.value = value),
connect: (source, node) => source.connect(node.delayTime),
},
} as const

export class EffectWrapper<T extends EffectName> {
Expand Down
4 changes: 4 additions & 0 deletions src/ostinato/schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ const zEffectNameBase = z.object({
'gain',
'distortion',
'volume',
'reverb',
'chorus',
'autowah',
'delay',
]),
})

Expand Down